[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] monitor/hmp-cmds: don't silently output when running 'migrat
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] monitor/hmp-cmds: don't silently output when running 'migrate_set_downtime' fails |
Date: |
Fri, 27 Mar 2020 11:22:27 +0000 |
User-agent: |
Mutt/1.13.3 (2020-01-12) |
* Mao Zhongyi (address@hidden) wrote:
> Although 'migrate_set_downtime' has been deprecated and replaced
> with 'migrate_set_parameter downtime_limit', it has not been
> completely eliminated, possibly due to compatibility with older
> versions. I think as long as this old parameter is running, we
> should report appropriate message when something goes wrong, not
> be silent.
>
> before:
> (qemu) migrate_set_downtime -1
> (qemu)
>
> after:
> (qemu) migrate_set_downtime -1
> Error: Parameter 'downtime_limit' expects an integer in the range of 0 to
> 2000 seconds
>
> Signed-off-by: Mao Zhongyi <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> monitor/hmp-cmds.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 9b94e67879..2a900a528a 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -1181,8 +1181,14 @@ void hmp_migrate_pause(Monitor *mon, const QDict
> *qdict)
> /* Kept for backwards compatibility */
> void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict)
> {
> + Error *err = NULL;
> +
> double value = qdict_get_double(qdict, "value");
> - qmp_migrate_set_downtime(value, NULL);
> + qmp_migrate_set_downtime(value, &err);
> +
> + if (err) {
> + hmp_handle_error(mon, err);
> + }
> }
>
> void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)
> --
> 2.17.1
>
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK