[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 07/12] configure: disable MTTCG for MIPS guests
From: |
Alex Bennée |
Subject: |
[PULL v2 07/12] configure: disable MTTCG for MIPS guests |
Date: |
Fri, 27 Mar 2020 18:13:15 +0000 |
While debugging check-acceptance failures I found an instability in
the mips64el test case. Briefly the test case:
retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \
-display none -vga none -serial mon:stdio \
-machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \
-cpu I6400 -smp 8 -vga std \
-append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1"
\
--no-reboot
Reports about a 9% failure rate:
Results summary:
0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation)
-6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation)
Ran command 100 times, 91 passes
When re-run with "--accel tcg,thread=single" the instability goes
away.
Results summary:
0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation)
Ran command 100 times, 100 passes
Which seems to indicate there is some aspect of the MIPS MTTCG fixes
that has been missed. Ideally we would fix that but I'm afraid I don't
have time to investigate and am not super familiar with the
architecture anyway. In lieu of someone tracking down the failure lets
disable it for now.
Signed-off-by: Alex Bennée <address@hidden>
Acked-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Aleksandar Rikalo <address@hidden>
Message-Id: <address@hidden>
diff --git a/configure b/configure
index 89fe881dd46..e225a1e3ffe 100755
--- a/configure
+++ b/configure
@@ -7887,7 +7887,7 @@ case "$target_name" in
TARGET_SYSTBL_ABI=n32
;;
mips64|mips64el)
- mttcg="yes"
+ mttcg="no"
TARGET_ARCH=mips64
TARGET_BASE_ARCH=mips
echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak
--
2.20.1
- [PULL v2 for 5.0 00/12] testing updates (+ one mttcg change), Alex Bennée, 2020/03/27
- [PULL v2 01/12] qemu/atomic.h: add #ifdef guards for stdatomic.h, Alex Bennée, 2020/03/27
- [PULL v2 03/12] tests/vm: move vga setup, Alex Bennée, 2020/03/27
- [PULL v2 02/12] tests/vm: write raw console log, Alex Bennée, 2020/03/27
- [PULL v2 04/12] tests/vm: update FreeBSD to 12.1, Alex Bennée, 2020/03/27
- [PULL v2 05/12] tests/vm: update NetBSD to 9.0, Alex Bennée, 2020/03/27
- [PULL v2 07/12] configure: disable MTTCG for MIPS guests,
Alex Bennée <=
- [PULL v2 09/12] tests/docker: Install gcrypt devel package in Debian image, Alex Bennée, 2020/03/27
- [PULL v2 06/12] tests/vm: fix basevm config, Alex Bennée, 2020/03/27
- [PULL v2 08/12] tests/docker: Keep package list sorted, Alex Bennée, 2020/03/27
- [PULL v2 10/12] tests/docker: Use Python3 PyYAML in the Fedora image, Alex Bennée, 2020/03/27
- [PULL v2 12/12] .travis.yml: Add a KVM-only s390x job, Alex Bennée, 2020/03/27
- [PULL v2 11/12] tests/docker: Add libepoxy and libudev packages to the Fedora image, Alex Bennée, 2020/03/27
- Re: [PULL v2 for 5.0 00/12] testing updates (+ one mttcg change), Peter Maydell, 2020/03/27