[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 00/74] per-CPU locks
From: |
Alex Bennée |
Subject: |
Re: [PATCH v8 00/74] per-CPU locks |
Date: |
Fri, 27 Mar 2020 18:23:05 +0000 |
User-agent: |
mu4e 1.3.10; emacs 28.0.50 |
Emilio G. Cota <address@hidden> writes:
> (Apologies if I missed some Cc's; I was not Cc'ed in patch 0
> so I'm blindly crafting a reply.)
>
<snip>
>> Changes for V8:
>> - Fixed issue where in rr mode we could destroy the BQL twice.
>
> I remember doing little to no testing in record-replay mode, so
> there should be more bugs hiding in there :-)
Well we have two (very simple) rr tests in check-tcg now - so there is
that ;-)
> On a related note, I've done some work to get QEMU-system to work
> under thread sanitizer, since tsan now supports our longjmp-based
> coroutines (hurrah!).
When did that go in? Will I need a new toolchain and -ltsan to make it
work?
> My idea was to integrate tsan in QEMU (i.e.
> bring tsan warnings to 0) before (re)trying to merge the
> per-CPU lock patchset; this would minimize the potential for
> regressions, which from my personal viewpoint seems like a reasonable
> thing to do especially now that I have little time to work on QEMU.
>
> If there's interest in doing the tsan work first, then I'd be
> happy to send to the list as soon as this weekend the changes that
> I have so far [1].
Please do - I've been cleaning up some of the other things the sanitizer
has found and it certainly won't hurt to get thread sanitizer working
again.
--
Alex Bennée
- [PATCH v8 73/74] cpu: add async_run_on_cpu_no_bql, (continued)
Re: [PATCH v8 00/74] per-CPU locks, Emilio G. Cota, 2020/03/27