[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/10] acpi: pcihp: fix left shift undefined behavior in acpi_pcih
From: |
Michael S. Tsirkin |
Subject: |
[PULL 04/10] acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot() |
Date: |
Tue, 31 Mar 2020 10:57:08 -0400 |
From: Igor Mammedov <address@hidden>
Coverity spots subj in following guest triggered code path
pci_write(, data = 0) -> acpi_pcihp_eject_slot(,slots = 0)
uinst32_t slot = ctz32(slots)
...
... = ~(1U << slot)
where 'slot' value is 32 in case 'slots' bitmap is empty.
'slots' is a bitmap and empty one shouldn't do anything
so return early doing nothing if resulted slot value is
not valid (i.e. not in 0-31 range)
Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/acpi/pcihp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index 4dcef372bf..0dc963e983 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -154,7 +154,7 @@ static void acpi_pcihp_eject_slot(AcpiPciHpState *s,
unsigned bsel, unsigned slo
trace_acpi_pci_eject_slot(bsel, slot);
- if (!bus) {
+ if (!bus || slot > 31) {
return;
}
--
MST
- [PULL 00/10] virtio, pci, pc: bugfixes, checkpatch, maintainers, Michael S. Tsirkin, 2020/03/31
- [PULL 01/10] checkpatch: enforce process for expected files, Michael S. Tsirkin, 2020/03/31
- [PULL 02/10] MAINTAINERS: Add myself as virtio-balloon co-maintainer, Michael S. Tsirkin, 2020/03/31
- [PULL 03/10] virtio-serial-bus: Plug memory leak on realize() error paths, Michael S. Tsirkin, 2020/03/31
- [PULL 04/10] acpi: pcihp: fix left shift undefined behavior in acpi_pcihp_eject_slot(),
Michael S. Tsirkin <=
- [PULL 06/10] virtio-iommu: avoid memleak in the unrealize, Michael S. Tsirkin, 2020/03/31
- [PULL 08/10] fix vhost_user_blk_watch crash, Michael S. Tsirkin, 2020/03/31
- [PULL 07/10] hw/i386/amd_iommu.c: Fix corruption of log events passed to guest, Michael S. Tsirkin, 2020/03/31
- [PULL 10/10] vhost-vsock: fix double close() in the realize() error path, Michael S. Tsirkin, 2020/03/31
- [PULL 05/10] virtio-blk: delete vqs on the error path in realize(), Michael S. Tsirkin, 2020/03/31
- [PULL 09/10] acpi: add acpi=OnOffAuto machine property to x86 and arm virt, Michael S. Tsirkin, 2020/03/31
- Re: [PULL 00/10] virtio, pci, pc: bugfixes, checkpatch, maintainers, Peter Maydell, 2020/03/31