[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev |
Date: |
Wed, 01 Apr 2020 11:08:56 +0200 |
On Dienstag, 31. März 2020 18:10:33 CEST Cornelia Huck wrote:
> > >> Huh. This prompted me to try this on s390, and it actually creates a
> > >> virtio-9p-pci device there as well, not a virtio-9p-ccw device. A bit
> > >> surprising; but I don't see 9p used much (if at all) on s390 anyway.
> > >
> > > Yeah, "virtio-9p-pci" is currently hard coded in softmmu/vl.c [line
> > > 3352]:
> > > https://github.com/qemu/qemu/blob/17083d6d1e0635371418c26b613a6fa68d392f
> > > 49/softmmu/vl.c#L3352>
> > Should it be "virtio-9p" instead? It's an alias for "virtio-9p-pci",
> > except for s390x, where it's an alias for "virtio-9p-ccw".
>
> Seems like a reasonable change (although I'm not sure it matters too
> much).
It would be a minor change it seems, and yes there seems to be a virtio-9p-ccw
implementation, however as long as nobody complains I leave it untouched for
now. Especially since I have no idea about the s390 architecture, nor testing
it.
Best regards,
Christian Schoenebeck
- Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev,
Christian Schoenebeck <=