Re: [RFC PATCH 1/1] ppc/spapr: Add hotplugged flag on DIMM LMBs on drmem_v2

[Bharata B Rao]

On Tue, Mar 10, 2020 at 8:24 AM David Gibson
<address@hidden> wrote:
>
> On Thu, Mar 05, 2020 at 09:22:02PM -0300, Leonardo Bras wrote:
> > On reboot, all memory that was previously added using object_add and
> > device_add is placed in this DIMM area.
> >
> > The new SPAPR_LMB_FLAGS_HOTPLUGGED flag helps Linux to put this memory in
> > the correct memory zone, so no unmovable allocations are made there,
> > allowing the object to be easily hot-removed by device_del and
> > object_del.
> >
> > Signed-off-by: Leonardo Bras <address@hidden>
> >
> > ---
> > The new flag was already proposed on Power Architecture documentation,
> > and it's waiting for approval.
> >
> > I would like to get your comments on this change, but it's still not
> > ready for being merged.
>
> This looks reasonable to me - at the very least it doesn't look like
> it could do much harm.

Looks good to me, also tested with PowerKVM guests.

Reviewed-by: Bharata B Rao <address@hidden>

Regards,
Bharata.
-- 
http://raobharata.wordpress.com/