Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes

[Fabian Grünbichler]

On February 25, 2020 10:54 pm, John Snow wrote:
> On 2/18/20 5:07 AM, Fabian Grünbichler wrote:
>> picking up on John's in-progress patch series from last summer, this is
>> a stab at rebasing and adding test cases for the low-hanging fruits:
>> 
>> - bitmap mirror mode with always/on-success/never bitmap sync mode
>> - incremental mirror mode as sugar for bitmap + on-success
>> 
>> Fabian Grünbichler (4):
>>   mirror: add check for bitmap-mode without bitmap
>>   mirror: switch to bdrv_dirty_bitmap_merge_internal
>>   iotests: add test for bitmap mirror
>>   mirror: move some checks to QMP
>> 
>> John Snow (2):
>>   drive-mirror: add support for sync=bitmap mode=never
>>   drive-mirror: add support for conditional and always bitmap sync modes
>> 
>>  include/block/block_int.h   |    4 +-
>>  block/mirror.c              |   96 +-
>>  blockdev.c                  |   71 +-
>>  tests/test-block-iothread.c |    4 +-
>>  qapi/block-core.json        |   29 +-
>>  tests/qemu-iotests/284      |  547 +++++++
>>  tests/qemu-iotests/284.out  | 2846 +++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/group    |    1 +
>>  8 files changed, 3567 insertions(+), 31 deletions(-)
>>  create mode 100755 tests/qemu-iotests/284
>>  create mode 100644 tests/qemu-iotests/284.out
>> 
> 
> Hi Fabian! Thanks for picking this up. I'm a bit behind on my mail, but
> this on my list to look at.
> 
> (Hint to other maintainers: It might be a while.)
> 
> --js

Hi,

ping? ;)

(it would be great to get some feedback as we'd like to ship this 
backported to 4.2 or 5.0 with our next point release)

kind regards,
Fabian