Re: [PATCH v1 5/5] i386: Hyper-V VMBus ACPI DSDT entry

[Maciej S. Szmigiero]

Hi Jon,

On 03.04.2020 16:23, Jon Doron wrote:
> Guest OS uses ACPI to discover vmbus presence.  Add a corresponding
> entry to DSDT in case vmbus has been enabled.
> 
> Experimentally Windows guests were found to require this entry to
> include two IRQ resources, so this patch adds two semi-arbitrarily
> chosen ones (7 and 13).  This results, in particular, in parallel port
> conflicting with vmbus.
> 
> TODO: discover and use spare IRQs to avoid conflicts.
> 
> Signed-off-by: Evgeny Yakovlev <address@hidden>
> Signed-off-by: Roman Kagan <address@hidden>
> Signed-off-by: Jon Doron <address@hidden>

Nice work, thanks!

However, it seems to be based on the code version that was posted in 
February 2018, and not the latest version in OpenVZ qemu repository
dated October 2019:
https://src.openvz.org/projects/UP/repos/qemu/commits?until=refs%2Fheads%2Fvmbus

This newer version has slightly different API here and there.
Any particular reason for selecting that older version for porting?

I have actually rebased this latest version on the top of the current
QEMU master, and it basically seems to work fine.
However, I haven't done extensive tests whether there isn't a memory leak
somewhere or so on.

Maciej