Re: [PATCH v1 0/5] hyperv: VMBus implementation

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v1 0/5] hyperv: VMBus implementation
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f79ca2e i386: Hyper-V VMBus ACPI DSDT entry
d2715b7 vmbus: vmbus implementation
00f328e vmbus: add vmbus protocol definitions
8a097ec hyperv: SControl is optional to enable SynIc
2dfe4b0 hyperv: expose API to determine if synic is enabled

=== OUTPUT BEGIN ===
1/5 Checking commit 2dfe4b0090be (hyperv: expose API to determine if synic is 
enabled)
2/5 Checking commit 8a097ec3667f (hyperv: SControl is optional to enable SynIc)
3/5 Checking commit 00f328eb4254 (vmbus: add vmbus protocol definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

ERROR: do not use C99 // comments
#135: FILE: include/hw/vmbus/vmbus-proto.h:114:
+    uint8_t  monitor_flags;      // VMBUS_OFFER_MONITOR_*

ERROR: do not use C99 // comments
#136: FILE: include/hw/vmbus/vmbus-proto.h:115:
+    uint16_t interrupt_flags;    // VMBUS_OFFER_INTERRUPT_*

ERROR: do not use C99 // comments
#213: FILE: include/hw/vmbus/vmbus-proto.h:192:
+    uint32_t feature_bits;     // VMBUS_RING_BUFFER_FEAT_*

total: 3 errors, 1 warnings, 222 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/5 Checking commit d2715b789821 (vmbus: vmbus implementation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#106: 
new file mode 100644

ERROR: memory barrier without comment
#645: FILE: hw/vmbus/vmbus.c:505:
+    smp_mb();

ERROR: memory barrier without comment
#706: FILE: hw/vmbus/vmbus.c:566:
+    smp_mb();

ERROR: "(foo*)" should be "(foo *)"
#1547: FILE: hw/vmbus/vmbus.c:1407:
+    vmbus_msg = (struct vmbus_message_header*)msg->payload;

ERROR: "(foo*)" should be "(foo *)"
#2036: FILE: hw/vmbus/vmbus.c:1896:
+    msg = (struct vmbus_message_header*)msgdata;

ERROR: space required before the open parenthesis '('
#2088: FILE: hw/vmbus/vmbus.c:1948:
+    switch(vmbus->state) {

WARNING: line over 80 characters
#2325: FILE: hw/vmbus/vmbus.c:2185:
+        VMSTATE_STRUCT_VARRAY_POINTER_UINT16(channels, VMBusDevice, 
num_channels,

ERROR: spaces required around that '*' (ctx:VxV)
#2532: FILE: hw/vmbus/vmbus.c:2392:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 6 errors, 2 warnings, 2585 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit f79ca2e47cca (i386: Hyper-V VMBus ACPI DSDT entry)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden