Re: [PATCH] hax: Dynamic allocate vcpu state structure

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] hax: Dynamic allocate vcpu state structure
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
0f29908 hax: Dynamic allocate vcpu state structure

=== OUTPUT BEGIN ===
ERROR: space required before the open brace '{'
#45: FILE: target/i386/hax-all.c:262:
+    if (max_cpus > HAX_MAX_VCPU){

ERROR: line over 90 characters
#46: FILE: target/i386/hax-all.c:263:
+        fprintf(stderr, "Failed to create vm, maximum possible VCPU number 
supported by QEMU is %d\n", HAX_MAX_VCPU);

ERROR: space required before the open brace '{'
#52: FILE: target/i386/hax-all.c:269:
+    for(i = 0; i < vm->numvcpus; i++){

ERROR: space required before the open parenthesis '('
#52: FILE: target/i386/hax-all.c:269:
+    for(i = 0; i < vm->numvcpus; i++){

ERROR: spaces required around that '=' (ctx:VxV)
#53: FILE: target/i386/hax-all.c:270:
+        vm->vcpus[i]=NULL;
                     ^

total: 5 errors, 0 warnings, 85 lines checked

Commit 0f299088bd75 (hax: Dynamic allocate vcpu state structure) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden