[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/11] target/arm: Remove obsolete TODO note from get_phys_addr_lp
From: |
Peter Maydell |
Subject: |
[PULL 04/11] target/arm: Remove obsolete TODO note from get_phys_addr_lpae() |
Date: |
Mon, 6 Apr 2020 11:11:58 +0100 |
An old comment in get_phys_addr_lpae() claims that the code does not
support the different format TCR for VTCR_EL2. This used to be true
but it is not true now (in particular the aa64_va_parameters() and
aa32_va_parameters() functions correctly handle the different
register format by checking whether the mmu_idx is Stage2).
Remove the out of date parts of the comment.
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-id: address@hidden
---
target/arm/helper.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/target/arm/helper.c b/target/arm/helper.c
index ed7eb8ab54e..7e9ea5d20fa 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -10753,12 +10753,7 @@ static bool get_phys_addr_lpae(CPUARMState *env,
target_ulong address,
bool aarch64 = arm_el_is_aa64(env, el);
bool guarded = false;
- /* TODO:
- * This code does not handle the different format TCR for VTCR_EL2.
- * This code also does not support shareability levels.
- * Attribute and permission bit handling should also be checked when adding
- * support for those page table walks.
- */
+ /* TODO: This code does not support shareability levels. */
if (aarch64) {
param = aa64_va_parameters(env, address, mmu_idx,
access_type != MMU_INST_FETCH);
--
2.20.1
- [PULL 00/11] target-arm queue, Peter Maydell, 2020/04/06
- [PULL 02/11] hw/arm/collie: Put StrongARMState* into a CollieMachineState struct, Peter Maydell, 2020/04/06
- [PULL 03/11] target/arm: PSTATE.PAN should not clear exec bits, Peter Maydell, 2020/04/06
- [PULL 04/11] target/arm: Remove obsolete TODO note from get_phys_addr_lpae(),
Peter Maydell <=
- [PULL 05/11] hw/gpio/aspeed_gpio.c: Don't directly include assert.h, Peter Maydell, 2020/04/06
- [PULL 06/11] dump: Fix writing of ELF section, Peter Maydell, 2020/04/06
- [PULL 08/11] dma/xlnx-zdma: Populate DBG0.CMN_BUF_FREE, Peter Maydell, 2020/04/06
- [PULL 09/11] dma/xlnx-zdma: Clear DMA_DONE when halting, Peter Maydell, 2020/04/06
- [PULL 01/11] target/arm: don't expose "ieee_half" via gdbstub, Peter Maydell, 2020/04/06
- [PULL 07/11] dma/xlnx-zdma: Remove comment, Peter Maydell, 2020/04/06
- [PULL 11/11] dma/xlnx-zdma: Reorg to fix CUR_DSCR, Peter Maydell, 2020/04/06
- [PULL 10/11] dma/xlnx-zdma: Advance the descriptor address when stopping, Peter Maydell, 2020/04/06
- Re: [PULL 00/11] target-arm queue, Peter Maydell, 2020/04/06