[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] hw/usb/xen-usb.c: Pass struct usbback_req* to usbback_packet_c
From: |
Anthony PERARD |
Subject: |
Re: [RFC] hw/usb/xen-usb.c: Pass struct usbback_req* to usbback_packet_complete() |
Date: |
Mon, 6 Apr 2020 18:43:23 +0100 |
On Mon, Mar 23, 2020 at 04:43:18PM +0000, Peter Maydell wrote:
> The function usbback_packet_complete() currently takes a USBPacket*,
> which must be a pointer to the packet field within a struct
> usbback_req; the function uses container_of() to get the struct
> usbback_req* given the USBPacket*.
>
> This is unnecessarily confusing (and in particular it confuses the
> Coverity Scan analysis, resulting in the false positive CID 1421919
> where it thinks that we write off the end of the structure). Since
> both callsites already have the pointer to the struct usbback_req,
> just pass that in directly.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This is an RFC because:
> * I'm not very familiar with the Xen bits of QEMU
> * the main rationale here is to change something that's
> confusing Coverity -- the code as it stands isn't wrong
> * the only testing I've done is "make check"
> Still, the change seems like a good thing to me as a human reader...
>
> PS: QEMU's MAINTAINERS file stanza for Xen doesn't pick up
> that this file is Xen related, so it could use an extra F: line.
Looks good,
Reviewed-by: Anthony PERARD <address@hidden>
Thanks,
--
Anthony PERARD
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC] hw/usb/xen-usb.c: Pass struct usbback_req* to usbback_packet_complete(),
Anthony PERARD <=