qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 12/12] configure: Add -Werror to PIE probe


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 12/12] configure: Add -Werror to PIE probe
Date: Mon, 6 Apr 2020 23:32:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/3/20 9:11 PM, Alex Bennée wrote:
From: Richard Henderson <address@hidden>

Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons.  Shows up on windows,
where the compiler complains about -fPIC.

Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

---
  configure | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 22870f38672..233c671aaa9 100755
--- a/configure
+++ b/configure
@@ -2119,7 +2119,7 @@ if compile_prog "-Werror -fno-pie" "-no-pie"; then
  fi
if test "$static" = "yes"; then
-  if test "$pie" != "no" && compile_prog "-fPIE -DPIE" "-static-pie"; then
+  if test "$pie" != "no" && compile_prog "-Werror -fPIE -DPIE" "-static-pie"; 
then
      QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
      QEMU_LDFLAGS="-static-pie $QEMU_LDFLAGS"
      pie="yes"
@@ -2132,7 +2132,7 @@ if test "$static" = "yes"; then
  elif test "$pie" = "no"; then
    QEMU_CFLAGS="$CFLAGS_NOPIE $QEMU_CFLAGS"
    QEMU_LDFLAGS="$LDFLAGS_NOPIE $QEMU_LDFLAGS"
-elif compile_prog "-fPIE -DPIE" "-pie"; then
+elif compile_prog "-Werror -fPIE -DPIE" "-pie"; then
    QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
    QEMU_LDFLAGS="-pie $QEMU_LDFLAGS"
    pie="yes"





reply via email to

[Prev in Thread] Current Thread [Next in Thread]