[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] nrf51: Fix last GPIO CNF address
From: |
Joel Stanley |
Subject: |
Re: [PATCH v1] nrf51: Fix last GPIO CNF address |
Date: |
Tue, 7 Apr 2020 08:45:14 +0000 |
On Tue, 7 Apr 2020 at 08:41, Peter Maydell <address@hidden> wrote:
>
> On Mon, 6 Apr 2020 at 23:55, Cameron Esfahani <address@hidden> wrote:
> >
> > NRF51_GPIO_REG_CNF_END doesn't actually refer to the start of the last
> > valid CNF register: it's referring to the last byte of the last valid
> > CNF register.
> >
> > This hasn't been a problem up to now, as current implementation in
> > memory.c turns an unaligned 4-byte read from 0x77f to a single byte read
> > and the qtest only looks at the least-significant byte of the register.
> >
> > But, when running with Cedric Le Goater's <address@hidden> pending fix for
> > unaligned accesses in memory.c, the qtest breaks.
>
> Do you have a link to this patch, please? I had a quick search through
> my mailing list articles but couldn't see anything obviously relevant.
There is a reference in this thread:
https://lore.kernel.org/qemu-devel/address@hidden/
The patch is here:
https://lore.kernel.org/qemu-devel/address@hidden/
Re: [PATCH v1] nrf51: Fix last GPIO CNF address, Philippe Mathieu-Daudé, 2020/04/07