[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] atomics: convert to reStructuredText
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 1/4] atomics: convert to reStructuredText |
|
Date: |
Tue, 7 Apr 2020 12:29:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 06/04/20 21:58, Eric Blake wrote:
>>
>> +For the purposes of pairing, ``smp_read_barrier_depends()`` and
>> ``smp_rmb()``
>> +both count as read barriers. A read barrier shall pair with a write
>> +barrier or a full barrier; a write barrier shall pair with a read
>
> 'shall' is awkward (if this is not a formal RFC-style requirement),
> better for colloquial English is 'must' or 'should' (twice)
Yes, it is a formal requirement. If you don't pair barriers, you don't
get any synchronization between the threads.
Thanks for the edits! I have included them, except when the text is
going to be removed by the next patch.
Paolo
- [PATCH 3/4] rcu: do not mention atomic_mb_read/set in documentation, (continued)
- [PATCH 3/4] rcu: do not mention atomic_mb_read/set in documentation, Paolo Bonzini, 2020/04/06
- [PATCH 4/4] async: use explicit memory barriers and relaxed accesses, Paolo Bonzini, 2020/04/06
- [PATCH 2/4] atomics: update documentation for C11, Paolo Bonzini, 2020/04/06
- [PATCH 1/4] atomics: convert to reStructuredText, Paolo Bonzini, 2020/04/06
- Re: [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures, Stefan Hajnoczi, 2020/04/07
- [RFC PATCH 0/4] async: fix hangs on weakly-ordered architectures, Paolo Bonzini, 2020/04/07
- [PATCH 1/5] atomics: convert to reStructuredText, Paolo Bonzini, 2020/04/07