[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0? v2] target/xtensa: Statically allocate xtensa_insnbu
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH for-5.0? v2] target/xtensa: Statically allocate xtensa_insnbufs in DisasContext |
|
Date: |
Tue, 7 Apr 2020 13:28:56 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 4/7/20 12:17 PM, Max Filippov wrote:
> On Tue, Apr 7, 2020 at 12:07 PM Richard Henderson
> <address@hidden> wrote:
>>
>> From: Max Filippov <address@hidden>
>>
>> Rather than dynamically allocate, and risk failing to free
>> when we longjmp out of the translator, allocate the maximum
>> buffer size from any of the supported cpus.
>>
>> Signed-off-by: Max Filippov <address@hidden>
>> [rth: Merged the fixup in Max's reply to his original]
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> target/xtensa/cpu.h | 3 +++
>> target/xtensa/helper.c | 1 +
>> target/xtensa/translate.c | 18 ++----------------
>> 3 files changed, 6 insertions(+), 16 deletions(-)
>
> I've re-posted it almost at the same time (:
> Should I take it, or do you have another plan for it?
I'm happy for you to take it.
r~