Re: [PATCH] Makefile: libfdt: build only the strict necessary

[Claudio Fontana]

On 4/8/20 11:08 AM, Daniel P. Berrangé wrote:
> On Wed, Apr 08, 2020 at 09:49:56AM +0200, Claudio Fontana wrote:
>> Hi,
>>
>> On 4/8/20 9:06 AM, address@hidden wrote:
>>> Patchew URL: https://patchew.org/QEMU/address@hidden/
>>>
>>>
>>>
>>> Hi,
>>>
>>> This series failed the asan build test. Please find the testing commands and
>>> their output below. If you have Docker installed, you can probably 
>>> reproduce it
>>> locally.
>>
>> I can't reproduce this here running the commands (TEST SCRIPT) below..
>>
>>>
>>> === TEST SCRIPT BEGIN ===
>>> #!/bin/bash
>>> export ARCH=x86_64
>>> make docker-image-fedora V=1 NETWORK=1
>>> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
>>> === TEST SCRIPT END ===
>>>
>>> === OUTPUT BEGIN ===
>>> Makefile:532: dtc/libfdt/Makefile.libfdt: No such file or directory
>>
>> hmm this is the include directive
>>
>> include $(LIBFDT_srcdir)/Makefile.libfdt
>>
>> is this test not getting the dtc submodule for some reason?
> 
> Note that this test script did not even get as far as trying to
> build QEMU itself.
> 
> Starting from a clean checkout *WITHOUT* having run configure,
> it is trying todo
> 
>    make docker-image-fedora V=1 NETWORK=1
> 
> This should invoke the rules to launch docker, and then run
> configure inside docker. Instead it is trying to build dtc.
> 
> So something in your changes has broken the ability to run
> the docker make targets.

Thanks, I can reproduce this now, will correct.

> 
>>
>>> cc -nostdlib  -o dtc/libfdt/Makefile.libfdt.mo 
>>
>> Hmm..
>>
>>> cc: fatal error: no input files
>>> compilation terminated.
>>> make: *** [dtc/libfdt/Makefile.libfdt.mo] Error 4
>>> Makefile:532: dtc/libfdt/Makefile.libfdt: No such file or directory
>>>   LD      dtc/libfdt/Makefile.libfdt.mo
>>> cc: fatal error: no input files
>>> compilation terminated.
>>> make: *** [dtc/libfdt/Makefile.libfdt.mo] Error 4
>>>
>>> real    0m0.585s
>>> user    0m0.384s
>>>
>>>
>>> The full log is available at
>>> http://patchew.org/logs/address@hidden/testing.asan/?type=message.
>>> ---
>>> Email generated automatically by Patchew [https://patchew.org/].
>>> Please send your feedback to address@hidden
>>>
>>
>>
> 
> Regards,
> Daniel
>