Re: [PATCH] hax: Windows doesn't like posix device names

[Paolo Bonzini]

On 09/04/20 15:24, Stefan Weil wrote:
>>> diff --git a/target/i386/hax-windows.c b/target/i386/hax-windows.c
>>> index 0ba488c468..863c2bcc19 100644
>>> --- a/target/i386/hax-windows.c
>>> +++ b/target/i386/hax-windows.c
>>> @@ -185,12 +185,12 @@ int hax_mod_version(struct hax_state *hax, struct 
>>> hax_module_version *version)
>>>  
>>>  static char *hax_vm_devfs_string(int vm_id)
>>>  {
>>> -    return g_strdup_printf("/dev/hax_vm/vm%02d", vm_id);
>>> +    return g_strdup_printf("\\\\.\\hax_vm%02d", vm_id);
>>>  }
>>>  
>>>  static char *hax_vcpu_devfs_string(int vm_id, int vcpu_id)
>>>  {
>>> -    return g_strdup_printf("/dev/hax_vm%02d/vcpu%02d", vm_id, vcpu_id);
>>> +    return g_strdup_printf("\\\\.\\hax_vm%02d_vcpu%02d", vm_id, vcpu_id);
>>>  }
>>>  
>>>  int hax_host_create_vm(struct hax_state *hax, int *vmid)
>>>
>> Queued, thanks.
>>
>> Paolo
> 
> I am rather sure that macOS does not like Windows device names, so just
> reverting might be the wrong solution if HAX should work on Windows and
> on macOS.

This is hax-windows.c, macOS uses hax-posix.c.  These days
Hypervisor.framework is probably a better choice than HAX on macOS, but
IIUC hax-posix.c also supports NetBSD so we're keeping it.

Paolo

> Is this relevant? Or should we drop HAX support for Windows? Personally
> I have no experience with hardware acceleration for QEMU on macOS.