qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH for-5.0? 0/9] block/io: safer inc/dec in_flight sections
Date: Thu, 9 Apr 2020 21:49:50 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

09.04.2020 20:00, Stefan Hajnoczi wrote:
On Wed, Apr 08, 2020 at 12:30:42PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

This is inspired by Kevin's
"block: Fix blk->in_flight during blk_wait_while_drained()" series.

So, like it's now done for block-backends, let's expand
in_flight-protected sections for bdrv_ interfaces, including
coroutine_enter and BDRV_POLL_WHILE loop into these sections.

This looks like a code improvement but let's leave it for the next
release since QEMU 5.0 is in freeze and this patch series does not fix a
specific user-visible bug.

I will review this in depth next week.  Thanks!


Hmm, it possibly fixes some bugs, but at least I didn't see them :) Anyway, it 
shouldn't be a degradation.

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]