Re: [PATCH 2/2] gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

[Philippe Mathieu-Daudé]

On 4/9/20 8:01 PM, Peter Xu wrote:
> Hi, Phil,
>
> On Thu, Apr 09, 2020 at 07:21:04PM +0200, Philippe Mathieu-Daudé wrote:
> > On 4/9/20 6:49 PM, Peter Xu wrote:
> > > We should only pass in gdb_get_reg16() with the GByteArray* object
> > > itself, no need to shift.  Without this patch, gdb remote attach will
> > > crash QEMU.
> >
> > You are correct.
> >
> > Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
>
> Oh I forgot to paste the fix line.  However, is it b7b8756a9c
> ("target/i386: use gdb_get_reg helpers", 2020-03-17) instead?

b7b8756a9c is correct, at that time the codebase was using the correct 
API. the next commit updated the API but missed to update the lines you 
are fixed. So I think "fixes a010bdbe719" is correct.

> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> Thanks!
>
> > Same problem in m68k_fpu_gdb_get_reg().
> >
> > TODO for 5.1, rename mem_buf -> array.