[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 05/48] nvme: use constants in identify
From: |
Klaus Jensen |
Subject: |
[PATCH v7 05/48] nvme: use constants in identify |
Date: |
Wed, 15 Apr 2020 07:50:57 +0200 |
From: Klaus Jensen <address@hidden>
Signed-off-by: Klaus Jensen <address@hidden>
Reviewed-by: Maxim Levitsky <address@hidden>
---
hw/block/nvme.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 088668f28bae..622103c42d0a 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -679,7 +679,7 @@ static uint16_t nvme_identify_ns(NvmeCtrl *n, NvmeIdentify
*c)
static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdentify *c)
{
- static const int data_len = 4 * KiB;
+ static const int data_len = NVME_IDENTIFY_DATA_SIZE;
uint32_t min_nsid = le32_to_cpu(c->nsid);
uint64_t prp1 = le64_to_cpu(c->prp1);
uint64_t prp2 = le64_to_cpu(c->prp2);
@@ -709,11 +709,11 @@ static uint16_t nvme_identify(NvmeCtrl *n, NvmeCmd *cmd)
NvmeIdentify *c = (NvmeIdentify *)cmd;
switch (le32_to_cpu(c->cns)) {
- case 0x00:
+ case NVME_ID_CNS_NS:
return nvme_identify_ns(n, c);
- case 0x01:
+ case NVME_ID_CNS_CTRL:
return nvme_identify_ctrl(n, c);
- case 0x02:
+ case NVME_ID_CNS_NS_ACTIVE_LIST:
return nvme_identify_nslist(n, c);
default:
trace_nvme_dev_err_invalid_identify_cns(le32_to_cpu(c->cns));
--
2.26.0
- [PATCH v7 00/48] nvme: support NVMe v1.3d, SGLs and multiple namespaces, Klaus Jensen, 2020/04/15
- [PATCH v7 02/48] nvme: remove superfluous breaks, Klaus Jensen, 2020/04/15
- [PATCH v7 06/48] nvme: refactor nvme_addr_read, Klaus Jensen, 2020/04/15
- [PATCH v7 07/48] nvme: add support for the abort command, Klaus Jensen, 2020/04/15
- [PATCH v7 03/48] nvme: move device parameters to separate struct, Klaus Jensen, 2020/04/15
- [PATCH v7 05/48] nvme: use constants in identify,
Klaus Jensen <=
- [PATCH v7 08/48] nvme: fix pci doorbell size calculation, Klaus Jensen, 2020/04/15
- [PATCH v7 09/48] nvme: add max_ioqpairs device parameter, Klaus Jensen, 2020/04/15
- [PATCH v7 04/48] nvme: bump spec data structures to v1.3, Klaus Jensen, 2020/04/15
- [PATCH v7 10/48] nvme: remove redundant cmbloc/cmbsz members, Klaus Jensen, 2020/04/15
- [PATCH v7 01/48] nvme: rename trace events to nvme_dev, Klaus Jensen, 2020/04/15
- [PATCH v7 11/48] nvme: refactor device realization, Klaus Jensen, 2020/04/15