[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 for-5.1 5/9] test-qemu-opts: Simplify test_has_help_option() a
From: |
Markus Armbruster |
Subject: |
[PATCH v2 for-5.1 5/9] test-qemu-opts: Simplify test_has_help_option() after bug fix |
Date: |
Wed, 15 Apr 2020 09:49:23 +0200 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
tests/test-qemu-opts.c | 36 +++++++++++++++++-------------------
1 file changed, 17 insertions(+), 19 deletions(-)
diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c
index 77c944c4aa..2a0f42a09b 100644
--- a/tests/test-qemu-opts.c
+++ b/tests/test-qemu-opts.c
@@ -732,41 +732,39 @@ static void test_has_help_option(void)
{
static const struct {
const char *params;
- /* expected value of has_help_option() */
- bool expect_has_help_option;
/* expected value of qemu_opt_has_help_opt() with implied=false */
- bool expect_opt_has_help_opt;
+ bool expect;
/* expected value of qemu_opt_has_help_opt() with implied=true */
- bool expect_opt_has_help_opt_implied;
+ bool expect_implied;
} test[] = {
- { "help", true, true, false },
- { "?", true, true, false },
- { "helpme", false, false, false },
- { "?me", false, false, false },
- { "a,help", true, true, true },
- { "a,?", true, true, true },
- { "a=0,help,b", true, true, true },
- { "a=0,?,b", true, true, true },
- { "help,b=1", true, true, false },
- { "?,b=1", true, true, false },
- { "a,b,,help", true, true, true },
- { "a,b,,?", true, true, true },
+ { "help", true, false },
+ { "?", true, false },
+ { "helpme", false, false },
+ { "?me", false, false },
+ { "a,help", true, true },
+ { "a,?", true, true },
+ { "a=0,help,b", true, true },
+ { "a=0,?,b", true, true },
+ { "help,b=1", true, false },
+ { "?,b=1", true, false },
+ { "a,b,,help", true, true },
+ { "a,b,,?", true, true },
};
int i;
QemuOpts *opts;
for (i = 0; i < ARRAY_SIZE(test); i++) {
g_assert_cmpint(has_help_option(test[i].params),
- ==, test[i].expect_has_help_option);
+ ==, test[i].expect);
opts = qemu_opts_parse(&opts_list_03, test[i].params, false,
&error_abort);
g_assert_cmpint(qemu_opt_has_help_opt(opts),
- ==, test[i].expect_opt_has_help_opt);
+ ==, test[i].expect);
qemu_opts_del(opts);
opts = qemu_opts_parse(&opts_list_03, test[i].params, true,
&error_abort);
g_assert_cmpint(qemu_opt_has_help_opt(opts),
- ==, test[i].expect_opt_has_help_opt_implied);
+ ==, test[i].expect_implied);
qemu_opts_del(opts);
}
}
--
2.21.1
- [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up, Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 3/9] qemu-option: Fix sloppy recognition of "id=..." after ", , ", Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 2/9] qemu-options: Factor out get_opt_name_value() helper, Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 1/9] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt(), Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 5/9] test-qemu-opts: Simplify test_has_help_option() after bug fix,
Markus Armbruster <=
- [PATCH v2 for-5.1 6/9] qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily(), Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 4/9] qemu-option: Fix has_help_option()'s sloppy parsing, Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 7/9] qemu-img: Factor out accumulate_options() helper, Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 9/9] qemu-img: Reject broken -o "", Markus Armbruster, 2020/04/15
- [PATCH v2 for-5.1 8/9] qemu-img: Move is_valid_option_list() to qemu-img.c and rewrite, Markus Armbruster, 2020/04/15
- Re: [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up, no-reply, 2020/04/15
- Re: [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up, Markus Armbruster, 2020/04/29