[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] hw/vfio: let read-only flag take effect for mmap'd re
From: |
Yan Zhao |
Subject: |
Re: [PATCH v3 3/3] hw/vfio: let read-only flag take effect for mmap'd regions |
Date: |
Wed, 15 Apr 2020 04:19:58 -0400 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Tue, Apr 14, 2020 at 05:37:58PM +0800, Philippe Mathieu-Daudé wrote:
> On 4/13/20 8:37 AM, Yan Zhao wrote:
> > along side setting host page table to be read-only, the memory regions
> > are also required to be read-only, so that when guest writes to the
> > read-only & mmap'd regions, vmexits would happen and region write handlers
> > are called.
> >
> > Signed-off-by: Yan Zhao <address@hidden>
> > Signed-off-by: Xin Zeng <address@hidden>
> > ---
> > hw/vfio/common.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> > index fd6ee1fe3e..fc7618e041 100644
> > --- a/hw/vfio/common.c
> > +++ b/hw/vfio/common.c
> > @@ -977,6 +977,10 @@ int vfio_region_mmap(VFIORegion *region)
> > name, region->mmaps[i].size,
> > region->mmaps[i].mmap);
> > g_free(name);
> > +
> > + if (!(region->flags & VFIO_REGION_INFO_FLAG_WRITE)) {
> > + memory_region_set_readonly(®ion->mmaps[i].mem, true);
> > + }
> > memory_region_add_subregion(region->mem, region->mmaps[i].offset,
> > ®ion->mmaps[i].mem);
> >
> >
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Thanks!