[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3
From: |
Peter Maydell |
Subject: |
Re: [PATCH RFC] configure: prefer sphinx-build to sphinx-build-3 |
Date: |
Thu, 16 Apr 2020 20:16:53 +0100 |
On Thu, 16 Apr 2020 at 19:22, John Snow <address@hidden> wrote:
> My goal is to make virtual environments work out of the box.
>
> I.e., if you run ./configure from inside a VENV, it should "just work."
Yeah, this seems reasonable to me. If I understand your
patch correctly it ought to work without breaking
the setup Markus describes, because in that case
'sphinx-build' exists but will fail the test_sphinx_build
step (because it's a Python 2 sphinx-build) and we'll
then move on and use sphinx-build-3.
Patch looks good to me, but you'll need to rebase and update it
to take account of commits 516e8b7d4a and 988ae6c3a7
now in master.
thanks
-- PMM