Re: [PATCH] target/arm: Vectorize integer comparison vs zero

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] target/arm: Vectorize integer comparison vs zero
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ecaee24 target/arm: Vectorize integer comparison vs zero

=== OUTPUT BEGIN ===
ERROR: spaces required around that '==' (ctx:WxB)
#526: FILE: target/arm/vec_helper.c:1272:
+DO_CMP0(gvec_ceq0_b, int8_t, ==)
                              ^

ERROR: spaces required around that '<' (ctx:WxB)
#527: FILE: target/arm/vec_helper.c:1273:
+DO_CMP0(gvec_clt0_b, int8_t, <)
                              ^

ERROR: spaces required around that '<=' (ctx:WxB)
#528: FILE: target/arm/vec_helper.c:1274:
+DO_CMP0(gvec_cle0_b, int8_t, <=)
                              ^

ERROR: spaces required around that '>' (ctx:WxB)
#529: FILE: target/arm/vec_helper.c:1275:
+DO_CMP0(gvec_cgt0_b, int8_t, >)
                              ^

ERROR: spaces required around that '>=' (ctx:WxB)
#530: FILE: target/arm/vec_helper.c:1276:
+DO_CMP0(gvec_cge0_b, int8_t, >=)
                              ^

ERROR: spaces required around that '==' (ctx:WxB)
#532: FILE: target/arm/vec_helper.c:1278:
+DO_CMP0(gvec_ceq0_h, int16_t, ==)
                               ^

ERROR: spaces required around that '<' (ctx:WxB)
#533: FILE: target/arm/vec_helper.c:1279:
+DO_CMP0(gvec_clt0_h, int16_t, <)
                               ^

ERROR: spaces required around that '<=' (ctx:WxB)
#534: FILE: target/arm/vec_helper.c:1280:
+DO_CMP0(gvec_cle0_h, int16_t, <=)
                               ^

ERROR: spaces required around that '>' (ctx:WxB)
#535: FILE: target/arm/vec_helper.c:1281:
+DO_CMP0(gvec_cgt0_h, int16_t, >)
                               ^

ERROR: spaces required around that '>=' (ctx:WxB)
#536: FILE: target/arm/vec_helper.c:1282:
+DO_CMP0(gvec_cge0_h, int16_t, >=)
                               ^

total: 10 errors, 0 warnings, 488 lines checked

Commit ecaee24ecb77 (target/arm: Vectorize integer comparison vs zero) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden