Re: [RFC v2 0/6] hmp, qmp: Add some commands to introspect virtio devices

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [RFC v2 0/6] hmp,qmp: Add some commands to introspect virtio devices
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   20038cd..ff0507c  master     -> master
Switched to a new branch 'test'
eaf8d3f hmp: add virtio commands
cb4b58b qmp: add QMP command virtio-queue-element
e658c99 qmp: add QMP command virtio-queue-status
4d0287d qmp: decode feature bits in virtio-status
016ad6d qmp: add QMP command virtio-status
6816985 qmp: add QMP command query-virtio

=== OUTPUT BEGIN ===
1/6 Checking commit 68169851a4da (qmp: add QMP command query-virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 180 lines checked

Patch 1/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/6 Checking commit 016ad6d70139 (qmp: add QMP command virtio-status)
3/6 Checking commit 4d0287d3f204 (qmp: decode feature bits in virtio-status)
4/6 Checking commit e658c99cb0bf (qmp: add QMP command virtio-queue-status)
5/6 Checking commit cb4b58babd76 (qmp: add QMP command virtio-queue-element)
6/6 Checking commit eaf8d3f50b01 (hmp: add virtio commands)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67: 
new file mode 100644

ERROR: trailing whitespace
#149: FILE: hmp-commands-virtio.hx:78:
+        Backend features: $

ERROR: spaces required around that '*' (ctx:WxV)
#344: FILE: hw/virtio/virtio.c:4095:
+        type##FeatureList *list = features->device->u.field.data;          \
                           ^

total: 2 errors, 1 warnings, 480 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden