[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fcntl: Add 32bit filesystem mode
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] fcntl: Add 32bit filesystem mode |
|
Date: |
Mon, 20 Apr 2020 16:29:32 +0100 |
On Mon, 20 Apr 2020 at 16:24, Eric Blake <address@hidden> wrote:
> It will be interesting to find how much code (wrongly) assumes it can
> use a blind assignment of fcntl(fd, F_SETFD, 1) and thereby accidentally
> wipes out other existing flags, when it should have instead been doing a
> read-modify-write to protect flags other than FD_CLOEXEC.
For instance, a quick grep shows 4 instances of this in QEMU :-)
thanks
-- PMM