Re: [PATCH v3 01/10] iotests/277: use dot slash for nbd-fault-injector.py running

[Vladimir Sementsov-Ogievskiy]

21.04.2020 15:54, Eric Blake wrote:
> On 4/21/20 2:35 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Somehow, this doesn't work if you just call ./277. But check 277 works.
> > We are going to new iotests running framework, which will consider test
> > files as self-executable, so let's just change it now.
>
> This is a rather vague explanation. 

Yes, because I didn't understand why does it work with check:) But you make it 
clean.

> I'd prefer something a bit more forthcoming, maybe:
>
> If you run './check 277', check includes common.config which adjusts $PATH to 
> include '.' first, and therefore finds nbd-fault-injector.py on PATH.  But if 
> you run './277' directly, there is nothing to adjust PATH, and if '.' is not 
> already on your PATH by other means, the test fails because the executable is 
> not found.  Adjust how we invoke the helper executable to avoid needing a PATH 
> search in the first place.

That's better of course.

> At any rate, while the commit message could be improved, the fix itself is 
> reasonable.
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!


--
Best regards,
Vladimir