Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

[Daniel P . Berrangé]

On Tue, Apr 21, 2020 at 02:45:04PM +0000, Ani Sinha wrote:
> 
> 
> > On Apr 20, 2020, at 8:32 PM, Michael S. Tsirkin <address@hidden> wrote:
> > 
> > But I for one would like to focus on keeping PIIX stable
> > and focus development on q35.  Not bloating PIIX with lots of new
> > features is IMHO a good way to do that.
> 
> Does this mean this patch is a no-go then? :(

I'd support this patch, as I don't think it can really be described as
bloat or destabalizing. It is just adding a simple property to
conditionalize existing functionality.  Telling people to switch to Q35
is unreasonable as it is not a simple 1-1 conversion from existing use
of PIIX. Q35 has much higher complexity in its configuration, has higher
memory overhead per VM too, and lacks certain features of PIIX too.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|