[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}()
From: |
Peter Xu |
Subject: |
[PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}() |
Date: |
Tue, 21 Apr 2020 12:21:01 -0400 |
memory_region_transaction_{begin|commit}() could be too big when finalizing a
memory region. E.g., we should never attempt to update address space topology
during the finalize() of a memory region. Provide helpers for further use.
Signed-off-by: Peter Xu <address@hidden>
---
memory.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index 601b749906..e5d634d648 100644
--- a/memory.c
+++ b/memory.c
@@ -1054,10 +1054,20 @@ static void address_space_update_topology(AddressSpace
*as)
address_space_set_flatview(as);
}
+static void memory_region_transaction_push(void)
+{
+ memory_region_transaction_depth++;
+}
+
+static void memory_region_transaction_pop(void)
+{
+ memory_region_transaction_depth--;
+}
+
void memory_region_transaction_begin(void)
{
qemu_flush_coalesced_mmio_buffer();
- ++memory_region_transaction_depth;
+ memory_region_transaction_push();
}
void memory_region_transaction_commit(void)
@@ -1067,7 +1077,7 @@ void memory_region_transaction_commit(void)
assert(memory_region_transaction_depth);
assert(qemu_mutex_iothread_locked());
- --memory_region_transaction_depth;
+ memory_region_transaction_pop();
if (!memory_region_transaction_depth) {
if (memory_region_update_pending) {
flatviews_reset();
--
2.24.1
- [PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2020/04/21
- [PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}(),
Peter Xu <=
- [PATCH 2/8] memory: Don't do topology update in memory finalize(), Peter Xu, 2020/04/21
- [PATCH 4/8] cpus: Introduce qemu_cond_timedwait_iothread(), Peter Xu, 2020/04/21
- [PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2020/04/21
- [PATCH 5/8] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2020/04/21
- [PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), Peter Xu, 2020/04/21
- [PATCH 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2020/04/21
- [PATCH 8/8] memory: Delay the transaction pop() until commit completed, Peter Xu, 2020/04/21