[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported R
From: |
Markus Armbruster |
Subject: |
[PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size |
Date: |
Wed, 22 Apr 2020 15:48:14 +0200 |
Improve
$ ppc-softmmu/qemu-system-ppc -M sam460ex -m 4096
qemu-system-ppc: Max 1 banks of 2048 ,1024 ,512 ,256 ,128 ,64 ,32 MB
DIMM/bank supported
qemu-system-ppc: Possible valid RAM size: 2048
to
qemu-system-ppc: at most 1 bank of 2048, 1024, 512, 256, 128, 64, 32 MiB
each supported
Possible valid RAM size: 1024 MiB
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/ppc/ppc4xx_devs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/ppc4xx_devs.c b/hw/ppc/ppc4xx_devs.c
index 3376c43ff5..f1651e04d9 100644
--- a/hw/ppc/ppc4xx_devs.c
+++ b/hw/ppc/ppc4xx_devs.c
@@ -716,11 +716,11 @@ void ppc4xx_sdram_banks(MemoryRegion *ram, int nr_banks,
for (i = 0; sdram_bank_sizes[i]; i++) {
g_string_append_printf(s, "%" PRIi64 "%s",
sdram_bank_sizes[i] / MiB,
- sdram_bank_sizes[i + 1] ? " ," : "");
+ sdram_bank_sizes[i + 1] ? ", " : "");
}
- error_report("Max %d banks of %s MB DIMM/bank supported",
- nr_banks, s->str);
- error_report("Possible valid RAM size: %" PRIi64,
+ error_report("at most %d bank%s of %s MiB each supported",
+ nr_banks, nr_banks == 1 ? "" : "s", s->str);
+ error_printf("Possible valid RAM size: %" PRIi64 " MiB \n",
used_size ? used_size / MiB : sdram_bank_sizes[i - 1] / MiB);
g_string_free(s, true);
--
2.21.1
- [PATCH v2 0/4] smbus: SPD fixes, Markus Armbruster, 2020/04/22
- [PATCH v2 4/4] smbus: Fix spd_data_generate() for number of banks > 2, Markus Armbruster, 2020/04/22
- [PATCH v2 3/4] bamboo, sam460ex: Tidy up error message for unsupported RAM size,
Markus Armbruster <=
- Re: [PATCH v2 0/4] smbus: SPD fixes, no-reply, 2020/04/22
- Re: [PATCH v2 0/4] smbus: SPD fixes, Markus Armbruster, 2020/04/29