Re: [PATCH v2 17/36] tcg/optimize: Adjust TempOptInfo allocation

[Alex Bennée]

Alex Bennée <address@hidden> writes:

> Richard Henderson <address@hidden> writes:
>
>> Do not allocate a large block for indexing.  Instead, allocate
>> for each temporary as they are seen.
>>
>> In general, this will use less memory, if we consider that most
>> TBs do not touch every target register.  This also allows us to
>> allocate TempOptInfo for new temps created during optimization.
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>
> Reviewed-by: Alex Bennée <address@hidden>
<snip>
>>  
>> -static void init_arg_info(TempOptInfo *infos,
>> -                          TCGTempSet *temps_used, TCGArg arg)
>> +static void init_arg_info(TCGTempSet *temps_used, TCGArg arg)
>>  {
>> -    init_ts_info(infos, temps_used, arg_temp(arg));
>> +    init_ts_info(temps_used, arg_temp(arg));
>>  }

Although I've noticed this function which is only called once where as
others call init_ts_info directly. Any reason to keep it around?

-- 
Alex Bennée