[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 08/14] tests/tcg: drop inferior.was_attached() test
From: |
Alex Bennée |
Subject: |
[PATCH v1 08/14] tests/tcg: drop inferior.was_attached() test |
Date: |
Thu, 23 Apr 2020 18:05:51 +0100 |
This test seems flaky and reports attachment even when we failed to
negotiate the architecture. However the fetching of the guest
architecture will fail tripping up the gdb AttributeError which will
trigger our early no error status exit from the test
Signed-off-by: Alex Bennée <address@hidden>
---
tests/tcg/aarch64/gdbstub/test-sve-ioctl.py | 3 ---
tests/tcg/aarch64/gdbstub/test-sve.py | 3 ---
2 files changed, 6 deletions(-)
diff --git a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
index 387b2fc20a..972cf73c31 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
@@ -58,9 +58,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
diff --git a/tests/tcg/aarch64/gdbstub/test-sve.py
b/tests/tcg/aarch64/gdbstub/test-sve.py
index 5995689625..b96bdbb99a 100644
--- a/tests/tcg/aarch64/gdbstub/test-sve.py
+++ b/tests/tcg/aarch64/gdbstub/test-sve.py
@@ -59,9 +59,6 @@ def run_test():
#
try:
inferior = gdb.selected_inferior()
- if inferior.was_attached == False:
- print("SKIPPING (failed to attach)", file=sys.stderr)
- exit(0)
arch = inferior.architecture()
report(arch.name() == "aarch64", "connected to aarch64")
except (gdb.error, AttributeError):
--
2.20.1
- [PATCH v1 03/14] accel/tcg: Relax va restrictions on 64-bit guests, (continued)
- [PATCH v1 03/14] accel/tcg: Relax va restrictions on 64-bit guests, Alex Bennée, 2020/04/23
- [PATCH v1 02/14] exec/cpu-all: Use bool for have_guest_base, Alex Bennée, 2020/04/23
- [PATCH v1 04/14] .gitignore: include common build sub-directories, Alex Bennée, 2020/04/23
- [PATCH v1 01/14] linux-user: completely re-write init_guest_space, Alex Bennée, 2020/04/23
- [PATCH v1 06/14] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers, Alex Bennée, 2020/04/23
- [PATCH v1 05/14] configure: favour gdb-multiarch if we have it, Alex Bennée, 2020/04/23
- [PATCH v1 09/14] gdbstub: eliminate gdbserver_fd global, Alex Bennée, 2020/04/23
- [PATCH v1 07/14] tests/tcg: better trap gdb failures, Alex Bennée, 2020/04/23
- [PATCH v1 08/14] tests/tcg: drop inferior.was_attached() test,
Alex Bennée <=
- [PATCH v1 11/14] tests/guest-debug: use the unix socket for linux-user tests, Alex Bennée, 2020/04/23
- [PATCH v1 14/14] .travis.yml: drop MacOSX, Alex Bennée, 2020/04/23
- [PATCH v1 12/14] tests/tcg: add a multiarch linux-user gdb test, Alex Bennée, 2020/04/23
- [PATCH v1 13/14] .travis.yml: show free disk space at end of run, Alex Bennée, 2020/04/23
- [PATCH v1 10/14] gdbstub/linux-user: support debugging over a unix socket, Alex Bennée, 2020/04/23
- Re: [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis, no-reply, 2020/04/23
- Re: [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis, no-reply, 2020/04/23