Re: [PATCH 11/13] qapi: Assert non-input visitors see only valid alternate tags

[Eric Blake]

On 4/23/20 11:00 AM, Markus Armbruster wrote:
> An alternate type's visit_type_FOO() fails when it runs into an
> invalid ->type.
>
> This is appropriate with an input visitor: visit_start_alternate()
> sets ->type according to the input, and bad input can lead to bad
> ->type.
>
> It should never happen with an output, clone or dealloc visitor: if it
> did, the alternate being output, cloned or deallocated would be messed
> up beyond repair.  Assert that.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   scripts/qapi/visit.py | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org