Re: [PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

[David Hildenbrand]

On 24.04.20 09:53, Cornelia Huck wrote:
> On Fri, 24 Apr 2020 09:07:25 +0200
> David Hildenbrand <address@hidden> wrote:
> 
>>>>  GlobalProperty hw_compat_4_2[] = {
>>>>      { "virtio-blk-device", "queue-size", "128"},
>>>>      { "virtio-scsi-device", "virtqueue_size", "128"},  
>>>
>>> Okay, so the bit above is for after 5_0 is released then? Is there a  
>>
>> Yes.
>>
>>> way to queue up a reminder or something so we get to it when the time
>>> comes, or I just need to watch for 5.0 to come out and submit a patch
>>> then?  
>>
>> I think what happened usually happens is that someone introduces all the
>> compat machines, sometimes directly with empty hw_compat.
>>
>> E.g., see
>>
>> commit 3eb74d2087d3bd6cb51c06a49ba94222248d2de4
>> Author: Cornelia Huck <address@hidden>
>> Date:   Tue Nov 12 11:48:11 2019 +0100
>>
>>     hw: add compat machines for 5.0
>>
>>     Add 5.0 machine types for arm/i440fx/q35/s390x/spapr.
>>
>> and
>>
>> commit 9aec2e52ce9d9632a86be2d1d0dd493722d2e7be
>> Author: Cornelia Huck <address@hidden>
>> Date:   Wed Jul 24 12:35:24 2019 +0200
>>
>>     hw: add compat machines for 4.2
>>
>>     Add 4.2 machine types for arm/i440fx/q35/s390x/spapr.
>>
>>
>> The latter already introduced hw_compat_4_1, for examnple.
>>
>> @Conny, do you already have a patch for 5.1 compat patch lying around
>> somewhere?
> 
> Not yet, will do so now. Thanks for the reminder, nearly forgot about
> that :)
> 

Awesome!

I just re-read my sentences and decided to consume more coffee before
starting to write emails in the morning. :)

-- 
Thanks,

David / dhildenb