Re: [PATCH 3/3] libqos: Give get_machine_allocator() internal linkage

[Philippe Mathieu-Daudé]

On 4/24/20 9:11 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   tests/qtest/libqos/qos_external.h | 2 --
>   tests/qtest/libqos/qos_external.c | 2 +-
>   2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/qtest/libqos/qos_external.h 
> b/tests/qtest/libqos/qos_external.h
> index f63388cb30..72d7f91707 100644
> --- a/tests/qtest/libqos/qos_external.h
> +++ b/tests/qtest/libqos/qos_external.h
> @@ -18,7 +18,6 @@
>   
>   #ifndef QOS_EXTERNAL_H
>   #define QOS_EXTERNAL_H
> -#include "libqos/qgraph.h"
>   
>   #include "libqos/malloc.h"
>   #include "qapi/qapi-types-machine.h"
> @@ -26,7 +25,6 @@
>   
>   void machines_apply_to_node(MachineInfoList *mach_info);
>   void types_apply_to_node(ObjectTypeInfoList *type_info);
> -QGuestAllocator *get_machine_allocator(QOSGraphObject *obj);
>   void *allocate_objects(QTestState *qts, char **path, QGuestAllocator 
> **p_alloc);
>   
>   #endif
> diff --git a/tests/qtest/libqos/qos_external.c 
> b/tests/qtest/libqos/qos_external.c
> index c707dac3b9..9f5180e18d 100644
> --- a/tests/qtest/libqos/qos_external.c
> +++ b/tests/qtest/libqos/qos_external.c
> @@ -66,7 +66,7 @@ void types_apply_to_node(ObjectTypeInfoList *type_info)
>       }
>   }
>   
> -QGuestAllocator *get_machine_allocator(QOSGraphObject *obj)
> +static QGuestAllocator *get_machine_allocator(QOSGraphObject *obj)
>   {
>       return obj->get_driver(obj, "memory");
>   }

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>