[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/15] qapi: Assert non-input visitors see only valid narrow i
From: |
Markus Armbruster |
Subject: |
[PATCH v2 09/15] qapi: Assert non-input visitors see only valid narrow integers |
Date: |
Fri, 24 Apr 2020 10:43:32 +0200 |
visit_type_intN() and visit_type_uintN() fail when the value is out of
bounds.
This is appropriate with an input visitor: the value comes from input,
and input may be bad.
It should never happen with the other visitors: the value comes from
the caller, and callers must keep it within bounds. Assert that.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qapi/qapi-visit-core.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
index 80ca83bcb9..74aa9c04bd 100644
--- a/qapi/qapi-visit-core.c
+++ b/qapi/qapi-visit-core.c
@@ -160,10 +160,13 @@ static void visit_type_uintN(Visitor *v, uint64_t *obj,
const char *name,
Error *err = NULL;
uint64_t value = *obj;
+ assert(v->type == VISITOR_INPUT || value <= max);
+
v->type_uint64(v, name, &value, &err);
if (err) {
error_propagate(errp, err);
} else if (value > max) {
+ assert(v->type == VISITOR_INPUT);
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", type);
} else {
@@ -219,10 +222,13 @@ static void visit_type_intN(Visitor *v, int64_t *obj,
const char *name,
Error *err = NULL;
int64_t value = *obj;
+ assert(v->type == VISITOR_INPUT || (value >= min && value <= max));
+
v->type_int64(v, name, &value, &err);
if (err) {
error_propagate(errp, err);
} else if (value < min || value > max) {
+ assert(v->type == VISITOR_INPUT);
error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
name ? name : "null", type);
} else {
--
2.21.1
- [PATCH v2 00/15] qapi: Spring cleaning, Markus Armbruster, 2020/04/24
- [PATCH v2 03/15] qapi: Fix typo in visit_start_list()'s contract, Markus Armbruster, 2020/04/24
- [PATCH v2 01/15] qapi: Belatedly update visitor.h's big comment for QAPI modules, Markus Armbruster, 2020/04/24
- [PATCH v2 04/15] qapi: Document @errp usage more thoroughly in visitor.h, Markus Armbruster, 2020/04/24
- [PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big comment, Markus Armbruster, 2020/04/24
- [PATCH v2 11/15] qapi: Assert non-input visitors see only valid alternate tags, Markus Armbruster, 2020/04/24
- [PATCH v2 13/15] qom: Simplify object_property_get_enum(), Markus Armbruster, 2020/04/24
- [PATCH v2 06/15] qapi: Assert incomplete object occurs only in dealloc visitor, Markus Armbruster, 2020/04/24
- [PATCH v2 09/15] qapi: Assert non-input visitors see only valid narrow integers,
Markus Armbruster <=
- [PATCH v2 14/15] qapi: Disallow qmp_marshal_FOO(NULL, ...), Markus Armbruster, 2020/04/24
- [PATCH v2 10/15] qapi: Clean up visitor's recovery from input with invalid type, Markus Armbruster, 2020/04/24
- [PATCH v2 15/15] qapi: Generate simpler marshalling code when no arguments, Markus Armbruster, 2020/04/24
- [PATCH v2 08/15] qapi: Assert output visitors see only valid enum values, Markus Armbruster, 2020/04/24
- [PATCH v2 12/15] qapi: Only input visitors can actually fail, Markus Armbruster, 2020/04/24
- [PATCH v2 07/15] qapi: Fix Visitor contract for start_alternate(), Markus Armbruster, 2020/04/24
- [PATCH v2 05/15] qapi: Polish prose in visitor.h, Markus Armbruster, 2020/04/24