qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 0/2] Replaced locks with lock guard macros


From: Stefan Hajnoczi
Subject: Re: [PATCH v5 0/2] Replaced locks with lock guard macros
Date: Fri, 24 Apr 2020 11:50:37 +0100

On Fri, Apr 03, 2020 at 09:21:06PM -0700, address@hidden wrote:
> From: Daniel Brodsky <address@hidden>
> 
> This patch set adds:
> - a fix for lock guard macros so they can be used multiple times in
> the same function
> - replacement of locks with lock guards where appropriate
> 
> v4 -> v5:
> - added G_GNUC_UNUSED to lock guard macro to supress unused var warning
> 
> v3 -> v4:
> - removed unneeded unlocks from areas where lock guards are now used
> - dropped change to lock guard in iscsi.c as it changed old functionality
> 
> v2 -> v3:
> - added __COUNTER__ fix for additional lock guard macro
> - added missing include header in platform.c
> 
> v1 -> v2:
> - fixed whitespace churn
> - added cover letter so patch set referenced correctly
> 
> Daniel Brodsky (2):
>   lockable: fix __COUNTER__ macro to be referenced properly
>   lockable: replaced locks with lock guard macros where appropriate
> 
>  block/iscsi.c           |  7 ++----
>  block/nfs.c             | 51 +++++++++++++++++++----------------------
>  cpus-common.c           | 14 ++++-------
>  hw/display/qxl.c        | 43 ++++++++++++++++------------------
>  hw/vfio/platform.c      |  5 ++--
>  include/qemu/lockable.h |  7 +++---
>  include/qemu/rcu.h      |  2 +-
>  migration/migration.c   |  3 +--
>  migration/multifd.c     |  8 +++----
>  migration/ram.c         |  3 +--
>  monitor/misc.c          |  4 +---
>  ui/spice-display.c      | 14 +++++------
>  util/log.c              |  4 ++--
>  util/qemu-timer.c       | 17 +++++++-------
>  util/rcu.c              |  8 +++----
>  util/thread-pool.c      |  3 +--
>  util/vfio-helpers.c     |  5 ++--
>  17 files changed, 88 insertions(+), 110 deletions(-)

Paolo, hope you don't mind if I use the block-next branch to merge this
and Simran's patch that depends on it.

Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next

Stefan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]