[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting refer
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v22 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint' |
Date: |
Mon, 27 Apr 2020 17:10:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 27.04.20 17:08, Alexander Duyck wrote:
> On Mon, Apr 27, 2020 at 1:15 AM David Hildenbrand <address@hidden> wrote:
>>
>> There is only one wrong comment remaining I think. Something like
>>
>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>> index a1d6fb52c8..1b2127c04c 100644
>> --- a/hw/virtio/virtio-balloon.c
>> +++ b/hw/virtio/virtio-balloon.c
>> @@ -554,8 +554,8 @@ static void virtio_balloon_free_page_stop(VirtIOBalloon
>> *s)
>> */
>> qemu_mutex_lock(&s->free_page_lock);
>> /*
>> - * The guest hasn't done the reporting, so host sends a notification
>> - * to the guest to actively stop the reporting.
>> + * The guest isn't done with hinting, so the host sends a
>> notification
>> + * to the guest to actively stop the hinting.
>
> I'll probably tweak it slightly and drop the "with". So the comment will read:
> /*
> * The guest isn't done hinting, so host sends a notification
I always feel like "so host sends" sounds wrong ("the host"). But I am
not a native speaker.
> * to the guest to actively stop the hinting.
> */
>
> There is one other spot left which is support for migration. The name
> for the VMStateDescription is
> "virtio-balloon-device/free-page-report". I am assuming I cannot
> rename that. Otherwise all other references to report on the balloon
> interface refer to reporting errors from what I can tell.
Yeah, that has to stay for migration to keep working.
--
Thanks,
David / dhildenb
[PATCH v22 QEMU 4/5] virtio-balloon: Implement support for page poison reporting feature, Alexander Duyck, 2020/04/24
[PATCH v22 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting, Alexander Duyck, 2020/04/24
Re: [PATCH v22 QEMU 0/5] virtio-balloon: add support for page poison reporting and free page reporting, David Hildenbrand, 2020/04/27