[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Fix undefined behaviour
From: |
Artur Puzio |
Subject: |
Re: [PATCH 1/2] Fix undefined behaviour |
Date: |
Tue, 28 Apr 2020 11:40:46 +0200 |
On 28.04.2020 10:10, Paul Durrant wrote:
>> -----Original Message-----
>> From: Grzegorz Uriasz <address@hidden>
>> Sent: 28 April 2020 07:29
>> To: address@hidden
>> Cc: Grzegorz Uriasz <address@hidden>; address@hidden; address@hidden;
>> address@hidden; address@hidden; Stefano Stabellini <address@hidden>; Anthony
>> Perard <address@hidden>; Paul Durrant <address@hidden>; address@hidden
>> Subject: [PATCH 1/2] Fix undefined behaviour
>>
>> Signed-off-by: Grzegorz Uriasz <address@hidden>
> I think we need more of a commit comment for both this and patch #2 to
> explain why you are making the changes.
>
> Paul
I agree Grzegorz should improve the commit messages. In the mean time
see email with subject "[PATCH 0/2] Fix QEMU crashes when passing IGD to
a guest VM under XEN", it contains quite detailed explanation for both
"Fix undefined behaviour" and "Improve legacy vbios handling" patches.
Artur Puzio
[PATCH 2/2] Improve legacy vbios handling, Grzegorz Uriasz, 2020/04/28