Re: [PATCH 0/3] account for NVDIMM nodes during SRAT generation

[Verma, Vishal L]

On Mon, 2020-04-27 at 19:44 -0700, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
[..]
> 
> === OUTPUT BEGIN ===
> 1/3 Checking commit 08b7ee5e7ddf (diffs-allowed: add the SRAT AML to
> diffs-allowed)
> 2/3 Checking commit dcc96eb97d46 (hw/acpi-build: account for NVDIMM
> numa nodes in SRAT)
> ERROR: Do not add expected files together with tests, follow
> instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-
> tables-test-allowed-diff.h and hw/i386/acpi-build.c found
> 
> ERROR: Do not add expected files together with tests, follow
> instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-
> tables-test-allowed-diff.h and hw/i386/acpi-build.c found

I'm not sure I follow these errors - I think I followed the instructions
in bios-tables-test.c exactly.. Did I miss something?

> 
> total: 2 errors, 0 warnings, 32 lines checked
> 
> Patch 2/3 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 3/3 Checking commit 34c59d3a0232 (tests/acpi: update expected SRAT
> files)
> ERROR: Do not add expected files together with tests, follow
> instructions in tests/qtest/bios-tables-test.c: both
> tests/data/acpi/pc/SRAT.dimmpxm and hw/i386/acpi-build.c found
> 
> ERROR: Do not add expected files together with tests, follow
> instructions in tests/qtest/bios-tables-test.c: both
> tests/data/acpi/q35/SRAT.dimmpxm and hw/i386/acpi-build.c found
> 
> ERROR: Do not add expected files together with tests, follow
> instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-
> tables-test-allowed-diff.h and hw/i386/acpi-build.c found
> 
> ERROR: Do not add expected files together with tests, follow
> instructions in tests/qtest/bios-tables-test.c: both tests/qtest/bios-
> tables-test-allowed-diff.h and hw/i386/acpi-build.c found
> 
> total: 4 errors, 0 warnings, 1 lines checked
> 
> Patch 3/3 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden