[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/17] qom: Change object_property_get_uint16List() to match
From: |
Eric Blake |
Subject: |
Re: [PATCH 04/17] qom: Change object_property_get_uint16List() to match its doc |
Date: |
Tue, 28 Apr 2020 12:46:39 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 4/28/20 11:34 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster <address@hidden>
---
include/qom/object.h | 4 ++--
hw/core/machine-qmp-cmds.c | 6 +++---
qom/object.c | 9 +++++----
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index ccfa82e33d..5d1ed672c3 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -1331,8 +1331,8 @@ int object_property_get_enum(Object *obj, const char
*name,
Adding context:
/**
* object_property_get_uint16List:
* @obj: the object
* @name: the name of the property
* @list: the returned int list
* @errp: returns an error if this function fails
*
* Returns: the value of the property, converted to integers, or
* undefined if an error occurs (including when the property value is not
* an list of integers).
*/
-void object_property_get_uint16List(Object *obj, const char *name,
- uint16List **list, Error **errp);
+uint16List *object_property_get_uint16List(Object *obj, const char *name,
+ Error **errp);
Incomplete. The doc comments need to drop the @list line, as well as
s/undefined/#NULL/ in the Returns line.
With that fixed,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 00/17] qom: Spring cleaning, Markus Armbruster, 2020/04/28
- [PATCH 01/17] qom: Clearer reference counting in object_initialize_childv(), Markus Armbruster, 2020/04/28
- [PATCH 04/17] qom: Change object_property_get_uint16List() to match its doc, Markus Armbruster, 2020/04/28
- Re: [PATCH 04/17] qom: Change object_property_get_uint16List() to match its doc,
Eric Blake <=
- [PATCH 03/17] qom: Drop object_property_del_child()'s unused parameter @errp, Markus Armbruster, 2020/04/28
- [PATCH 02/17] qom: Clean up inconsistent use of gchar * vs. char *, Markus Armbruster, 2020/04/28
- [PATCH 07/17] tests/check-qom-proplist: Improve iterator coverage, Markus Armbruster, 2020/04/28
- [PATCH 06/17] qom: Drop object_property_set_description() parameter @errp, Markus Armbruster, 2020/04/28
- [PATCH 12/17] qdev: Clean up qdev_connect_gpio_out_named(), Markus Armbruster, 2020/04/28
- [PATCH 05/17] qom: Make all the object_property_add_FOO() return the property, Markus Armbruster, 2020/04/28