[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_str
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct() |
|
Date: |
Wed, 29 Apr 2020 07:51:04 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
David Hildenbrand <address@hidden> writes:
> On 24.04.20 21:20, Markus Armbruster wrote:
>> Commit e47970f51d "s390x/cpumodel: Fix query-cpu-model-FOO error API
>> violations" neglected to change visit_end_struct()'s Error ** argument
>> along with the others. If visit_end_struct() failed, we'd take the
>
> s/visit_end_struct/visit_check_struct/ ?
Will fix.
>> success path. Fortunately, it can't fail here:
>> qobject_input_check_struct() checks we consumed the whole dictionary,
>> and to get here, we did. Fix it anyway.
>
> AFAIKs, if visit_check_struct() failed, we'd still do the memcopy, but
> also report the error. Not nice, not bad.
>
> Reviewed-by: David Hildenbrand <address@hidden>
Thanks!
- [PATCH 06/11] error: Use error_reportf_err() where appropriate, (continued)
- [PATCH 07/11] mips/malta: Fix create_cps() error handling, Markus Armbruster, 2020/04/24
- [PATCH 03/11] s390x/cpumodel: Fix harmless misuse of visit_check_struct(), Markus Armbruster, 2020/04/24
- [PATCH 10/11] arm/sabrelite: Consistently use &error_fatal in sabrelite_init(), Markus Armbruster, 2020/04/24
- [PATCH 01/11] nvdimm: Plug memory leak in uuid property setter, Markus Armbruster, 2020/04/24
- [PATCH 08/11] mips/boston: Fix boston_mach_init() error handling, Markus Armbruster, 2020/04/24
- [PATCH 11/11] i386: Fix x86_cpu_load_model() error API violation, Markus Armbruster, 2020/04/24
- [PATCH 02/11] xen: Fix and improve handling of device_add usb-host errors, Markus Armbruster, 2020/04/24
- [PATCH 09/11] mips/boston: Plug memory leak in boston_mach_init(), Markus Armbruster, 2020/04/24