qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.1 v3 2/7] various: Use &error_abort in instance_init()


From: Markus Armbruster
Subject: Re: [PATCH-for-5.1 v3 2/7] various: Use &error_abort in instance_init()
Date: Wed, 29 Apr 2020 08:12:03 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Philippe Mathieu-Daudé <address@hidden> writes:

> Patch created mechanically by running:
>
>   $ spatch \
>     --macro-file scripts/cocci-macro-file.h \
>     --include-headers --keep-comments --in-place \
>     --sp-file \
>       scripts/coccinelle/use-error_abort-in-instance_init.cocci
>
> Reviewed-by: Cédric Le Goater <address@hidden>
> Acked-by: Cornelia Huck <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

This one clashes with my "[PATCH 00/17] qom: Spring cleaning".  Where
your patch replaces

    object_property_add_FOO(..., NULL);

by

    object_property_add_FOO(..., &error_abort);

mine drops the parameter outright.

Does not fully replace your patch, which touches other functions, too.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]