Re: [PATCH v22 4/4] iotests: 287: add qcow2 compression type test

[Max Reitz]

On 28.04.20 22:00, Denis Plotnikov wrote:
> The test checks fulfilling qcow2 requirements for the compression
> type feature and zstd compression type operability.
> 
> Signed-off-by: Denis Plotnikov <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Tested-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  tests/qemu-iotests/287     | 152 +++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/287.out |  67 ++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 220 insertions(+)
>  create mode 100755 tests/qemu-iotests/287
>  create mode 100644 tests/qemu-iotests/287.out
> 
> diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287
> new file mode 100755
> index 0000000000..21fe1f19f5
> --- /dev/null
> +++ b/tests/qemu-iotests/287
> @@ -0,0 +1,152 @@
> +#!/usr/bin/env bash
> +#
> +# Test case for an image using zstd compression
> +#
> +# Copyright (c) 2020 Virtuozzo International GmbH
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +# creator
> +owner=address@hidden
> +
> +seq="$(basename $0)"
> +echo "QA output created by $seq"
> +
> +status=1     # failure is the default!
> +
> +# standard environment
> +. ./common.rc
> +. ./common.filter
> +
> +# This tests qocw2-specific low-level functionality
> +_supported_fmt qcow2
> +_supported_proto file
> +_supported_os Linux
> +_unsupported_imgopts 'compat=0.10' data_file
> +
> +COMPR_IMG="$TEST_IMG.compressed"
> +RAND_FILE="$TEST_DIR/rand_data"
> +
> +_cleanup()
> +{
> +     _rm_test_img

_rm_test_img needs an argument (it basically replaces “rm”).  What I
thus meant was to keep the _cleanup_test_img here (that was completely
correct), but...

> +     rm -f "$COMPR_IMG"

...to use “_rm_test_img "$COMPR_IMG"” here instead of rm.

Max

signature.asc
Description: OpenPGP digital signature