Re: [PATCH for-5.1 V2 0/7] mips: Add Loongson-3 machine support (with KV

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1 V2 0/7] mips: Add Loongson-3 machine support (with KV

From:	no-reply
Subject:	Re: [PATCH for-5.1 V2 0/7] mips: Add Loongson-3 machine support (with KVM)
Date:	Thu, 30 Apr 2020 13:09:04 -0700 (PDT)
Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH for-5.1 V2 0/7] mips: Add Loongson-3 machine support (with KVM)
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
7b568a8 MAINTAINERS: Add myself as Loongson-3 maintainer
e188b58 hw/mips: Add Loongson-3 machine support (with KVM)
cd58c7b target/mips: Add more CP0 register for save/restore
febf0f7 target/mips: Add Loongson-3 CPU definition
811cf86 hw/mips: Add CPU IRQ3 delivery for KVM
b1c4913 hw/mips: Implement the kvm_type() hook in MachineClass
d5fd437 configure: Add KVM target support for MIPS64

=== OUTPUT BEGIN ===
1/7 Checking commit d5fd4379e217 (configure: Add KVM target support for MIPS64)
2/7 Checking commit b1c4913d34d3 (hw/mips: Implement the kvm_type() hook in 
MachineClass)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
new file mode 100644

ERROR: superfluous trailing semicolon
#88: FILE: hw/mips/common.c:18:
+    KVMState *s = KVM_STATE(machine->accelerator);;

ERROR: braces {} are necessary for all arms of this statement
#91: FILE: hw/mips/common.c:21:
+    if (r > 0)
[...]

ERROR: braces {} are necessary for all arms of this statement
#95: FILE: hw/mips/common.c:25:
+    if (r > 0)
[...]

total: 3 errors, 1 warnings, 68 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit 811cf860565a (hw/mips: Add CPU IRQ3 delivery for KVM)
ERROR: braces {} are necessary for all arms of this statement
#24: FILE: hw/mips/mips_int.c:51:
+        if (kvm_enabled() && (irq == 2 || irq == 3))
[...]

total: 1 errors, 0 warnings, 18 lines checked

Patch 3/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/7 Checking commit febf0f756c77 (target/mips: Add Loongson-3 CPU definition)
ERROR: code indent should never use tabs
#133: FILE: target/mips/translate_init.inc.c:815:
+^I^I       (3 << CP0C2_SA),$

ERROR: code indent should never use tabs
#162: FILE: target/mips/translate_init.inc.c:844:
+^I^I       (15 << CP0C2_SA),$

WARNING: line over 80 characters
#173: FILE: target/mips/translate_init.inc.c:855:
+        .CP0_Config6 = (1 << CP0C6_VCLRU) | (1 << CP0C6_DCLRU) | (1 << 
CP0C6_SFBEN) |

ERROR: line over 90 characters
#174: FILE: target/mips/translate_init.inc.c:856:
+                       (1 << CP0C6_FLTINT) | (1 << CP0C6_INSTPREF) | (1 << 
CP0C6_DATAPREF),

ERROR: line over 90 characters
#176: FILE: target/mips/translate_init.inc.c:858:
+                                  (1 << CP0C6_KE) | (1 << CP0C6_VTLBONLY) | (1 
<< CP0C6_LASX) |

WARNING: line over 80 characters
#181: FILE: target/mips/translate_init.inc.c:863:
+                                  (1 << CP0C6_PIXUEN) | (1 << 
CP0C6_DISBLKLYEN) |

WARNING: line over 80 characters
#187: FILE: target/mips/translate_init.inc.c:869:
+        .CP0_Config7_rw_bitmask = (1 << CP0C7_NAPCGEN) | (1 << CP0C7_UNIMUEN) 
| \

total: 4 errors, 3 warnings, 162 lines checked

Patch 4/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/7 Checking commit cd58c7be6558 (target/mips: Add more CP0 register for 
save/restore)
6/7 Checking commit e188b58a2e06 (hw/mips: Add Loongson-3 machine support (with 
KVM))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

ERROR: code indent should never use tabs
#126: FILE: hw/mips/mips_loongson3.c:44:
+#define INITRD_OFFSET^I^I0x04000000$

ERROR: code indent should never use tabs
#127: FILE: hw/mips/mips_loongson3.c:45:
+#define BOOTPARAM_ADDR^I^I0x8ff00000$

ERROR: code indent should never use tabs
#128: FILE: hw/mips/mips_loongson3.c:46:
+#define BOOTPARAM_PHYADDR^I0x0ff00000$

ERROR: code indent should never use tabs
#129: FILE: hw/mips/mips_loongson3.c:47:
+#define CFG_ADDR ^I^I0x0f100000$

ERROR: code indent should never use tabs
#130: FILE: hw/mips/mips_loongson3.c:48:
+#define FW_CONF_ADDR^I^I0x0fff0000$

ERROR: code indent should never use tabs
#131: FILE: hw/mips/mips_loongson3.c:49:
+#define PM_MMIO_ADDR^I^I0x10080000$

ERROR: code indent should never use tabs
#132: FILE: hw/mips/mips_loongson3.c:50:
+#define PM_MMIO_SIZE^I^I0x100$

ERROR: code indent should never use tabs
#133: FILE: hw/mips/mips_loongson3.c:51:
+#define PM_CNTL_MODE^I^I0x10$

ERROR: code indent should never use tabs
#143: FILE: hw/mips/mips_loongson3.c:61:
+#define PCIE_IRQ_BASE^I   3$

ERROR: missing space after struct definition
#158: FILE: hw/mips/mips_loongson3.c:76:
+    struct mem_map{

WARNING: line over 80 characters
#217: FILE: hw/mips/mips_loongson3.c:135:
+    uint32_t fan_policy; /* see 
arch/mips/include/asm/mach-loongson/loongson_hwmon.h */

WARNING: line over 80 characters
#352: FILE: hw/mips/mips_loongson3.c:270:
+    0x40086000,   /* mfc0    t0, CP0_STATUS                                    
    */

WARNING: line over 80 characters
#353: FILE: hw/mips/mips_loongson3.c:271:
+    0x240900E2,   /* li      t1, 0x00e2       
#{cu3,cu2,cu1,cu0,status_fr}<={0111} */

WARNING: line over 80 characters
#354: FILE: hw/mips/mips_loongson3.c:272:
+    0x01094025,   /* or      t0, t0, t1                                        
    */

WARNING: line over 80 characters
#355: FILE: hw/mips/mips_loongson3.c:273:
+    0x40886000,   /* mtc0    t0, CP0_STATUS                                    
    */

WARNING: line over 80 characters
#357: FILE: hw/mips/mips_loongson3.c:275:
+    0x40086000,   /* mfc0    t0, CP0_STATUS                                    
    */

WARNING: line over 80 characters
#358: FILE: hw/mips/mips_loongson3.c:276:
+    0x3C090040,   /* lui     t1, 0x40         #bev                             
    */

WARNING: line over 80 characters
#359: FILE: hw/mips/mips_loongson3.c:277:
+    0x01094025,   /* or      t0, t0, t1                                        
    */

WARNING: line over 80 characters
#360: FILE: hw/mips/mips_loongson3.c:278:
+    0x40886000,   /* mtc0    t0, CP0_STATUS                                    
    */

WARNING: line over 80 characters
#362: FILE: hw/mips/mips_loongson3.c:280:
+    0x40806800,   /* mtc0    zero, CP0_CAUSE                                   
    */

WARNING: line over 80 characters
#364: FILE: hw/mips/mips_loongson3.c:282:
+    0x400A7801,   /* mfc0    t2, $15, 1                                        
    */

WARNING: line over 80 characters
#365: FILE: hw/mips/mips_loongson3.c:283:
+    0x314A00FF,   /* andi    t2, 0x0ff                                         
    */

WARNING: line over 80 characters
#366: FILE: hw/mips/mips_loongson3.c:284:
+    0x3C089000,   /* dli     t0, 0x900000003ff01000                            
    */

WARNING: line over 80 characters
#371: FILE: hw/mips/mips_loongson3.c:289:
+    0x314B0003,   /* andi    t3, t2, 0x3      #local cpuid                     
    */

WARNING: line over 80 characters
#372: FILE: hw/mips/mips_loongson3.c:290:
+    0x000B5A00,   /* sll     t3, 8                                             
    */

WARNING: line over 80 characters
#373: FILE: hw/mips/mips_loongson3.c:291:
+    0x010B4025,   /* or      t0, t0, t3                                        
    */

WARNING: line over 80 characters
#374: FILE: hw/mips/mips_loongson3.c:292:
+    0x314C000C,   /* andi    t4, t2, 0xc      #node id                         
    */

WARNING: line over 80 characters
#375: FILE: hw/mips/mips_loongson3.c:293:
+    0x000C62BC,   /* dsll    t4, 42                                            
    */

WARNING: line over 80 characters
#376: FILE: hw/mips/mips_loongson3.c:294:
+    0x010C4025,   /* or      t0, t0, t4                                        
    */

WARNING: line over 80 characters
#377: FILE: hw/mips/mips_loongson3.c:295:
+                  /* waitforinit:                                              
    */

WARNING: line over 80 characters
#378: FILE: hw/mips/mips_loongson3.c:296:
+    0xDD020020,   /* ld      v0, FN_OFF(t0)   #FN_OFF 0x020                    
    */

WARNING: line over 80 characters
#379: FILE: hw/mips/mips_loongson3.c:297:
+    0x1040FFFE,   /* beqz    v0, waitforinit                                   
    */

WARNING: line over 80 characters
#380: FILE: hw/mips/mips_loongson3.c:298:
+    0x00000000,   /* nop                                                       
    */

WARNING: line over 80 characters
#381: FILE: hw/mips/mips_loongson3.c:299:
+    0xDD1D0028,   /* ld      sp, SP_OFF(t0)   #FN_OFF 0x028                    
    */

WARNING: line over 80 characters
#382: FILE: hw/mips/mips_loongson3.c:300:
+    0xDD1C0030,   /* ld      gp, GP_OFF(t0)   #FN_OFF 0x030                    
    */

WARNING: line over 80 characters
#383: FILE: hw/mips/mips_loongson3.c:301:
+    0xDD050038,   /* ld      a1, A1_OFF(t0)   #FN_OFF 0x038                    
    */

WARNING: line over 80 characters
#384: FILE: hw/mips/mips_loongson3.c:302:
+    0x00400008,   /* jr      v0               #byebye                          
    */

WARNING: line over 80 characters
#385: FILE: hw/mips/mips_loongson3.c:303:
+    0x00000000,   /* nop                                                       
    */

WARNING: line over 80 characters
#386: FILE: hw/mips/mips_loongson3.c:304:
+    0x1000FFFF,   /* 1:  b   1b                                                
    */

WARNING: line over 80 characters
#387: FILE: hw/mips/mips_loongson3.c:305:
+    0x00000000,   /* nop                                                       
    */

WARNING: line over 80 characters
#389: FILE: hw/mips/mips_loongson3.c:307:
+                  /* Reset                                                     
    */

WARNING: line over 80 characters
#390: FILE: hw/mips/mips_loongson3.c:308:
+    0x3C0C9000,   /* dli     t0, 0x9000000010080010                            
    */

WARNING: line over 80 characters
#396: FILE: hw/mips/mips_loongson3.c:314:
+    0x240D0000,   /* li      t1, 0x00                                          
    */

WARNING: line over 80 characters
#397: FILE: hw/mips/mips_loongson3.c:315:
+    0xA18D0000,   /* sb      t1, (t0)                                          
    */

WARNING: line over 80 characters
#398: FILE: hw/mips/mips_loongson3.c:316:
+    0x1000FFFF,   /* 1:  b   1b                                                
    */

WARNING: line over 80 characters
#399: FILE: hw/mips/mips_loongson3.c:317:
+    0x00000000,   /* nop                                                       
    */

WARNING: line over 80 characters
#401: FILE: hw/mips/mips_loongson3.c:319:
+                  /* Shutdown                                                  
    */

WARNING: line over 80 characters
#402: FILE: hw/mips/mips_loongson3.c:320:
+    0x3C0C9000,   /* dli     t0, 0x9000000010080010                            
    */

WARNING: line over 80 characters
#408: FILE: hw/mips/mips_loongson3.c:326:
+    0x240D00FF,   /* li      t1, 0xff                                          
    */

WARNING: line over 80 characters
#409: FILE: hw/mips/mips_loongson3.c:327:
+    0xA18D0000,   /* sb      t1, (t0)                                          
    */

WARNING: line over 80 characters
#410: FILE: hw/mips/mips_loongson3.c:328:
+    0x1000FFFF,   /* 1:  b   1b                                                
    */

WARNING: line over 80 characters
#411: FILE: hw/mips/mips_loongson3.c:329:
+    0x00000000    /* nop                                                       
    */

WARNING: line over 80 characters
#419: FILE: hw/mips/mips_loongson3.c:337:
+static void loongson3_pm_write(void *opaque, hwaddr addr, uint64_t 
val,unsigned size)

ERROR: space required after that ',' (ctx:VxV)
#419: FILE: hw/mips/mips_loongson3.c:337:
+static void loongson3_pm_write(void *opaque, hwaddr addr, uint64_t 
val,unsigned size)
                                                                       ^

ERROR: braces {} are necessary for all arms of this statement
#421: FILE: hw/mips/mips_loongson3.c:339:
+    if (addr != PM_CNTL_MODE)
[...]

ERROR: do not use assignment in if condition
#469: FILE: hw/mips/mips_loongson3.c:387:
+    if ((fd = open("/proc/cpuinfo", O_RDONLY)) == -1) {

ERROR: trailing statements should be on next line
#482: FILE: hw/mips/mips_loongson3.c:400:
+    while (*buf_p != '@') buf_p++;

ERROR: braces {} are necessary for all arms of this statement
#482: FILE: hw/mips/mips_loongson3.c:400:
+    while (*buf_p != '@') buf_p++;
[...]

ERROR: trailing statements should be on next line
#487: FILE: hw/mips/mips_loongson3.c:405:
+    while ((*buf_p >= '0') && (*buf_p <= '9')) buf_p++;

ERROR: braces {} are necessary for all arms of this statement
#487: FILE: hw/mips/mips_loongson3.c:405:
+    while ((*buf_p >= '0') && (*buf_p <= '9')) buf_p++;
[...]

ERROR: braces {} are necessary for all arms of this statement
#502: FILE: hw/mips/mips_loongson3.c:420:
+    if (!c->cpu_clock_freq)
[...]

ERROR: spaces required around that '+=' (ctx:VxW)
#595: FILE: hw/mips/mips_loongson3.c:513:
+    p+= align(sizeof(struct board_devices));
      ^

ERROR: spaces required around that '+=' (ctx:VxW)
#599: FILE: hw/mips/mips_loongson3.c:517:
+    p+= align(sizeof(struct loongson_special_attribute));
      ^

WARNING: line over 80 characters
#642: FILE: hw/mips/mips_loongson3.c:560:
+    fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, 
(uint16_t)current_machine->smp.max_cpus);

ERROR: spaces required around that '+' (ctx:VxV)
#684: FILE: hw/mips/mips_loongson3.c:602:
+        ret += (1 + snprintf(params_buf+ret, 256 - ret, "%s",
                                        ^

ERROR: spaces required around that '*' (ctx:VxV)
#688: FILE: hw/mips/mips_loongson3.c:606:
+    *parg_env++ = BOOTPARAM_ADDR + 4*ret;
                                     ^

WARNING: line over 80 characters
#791: FILE: hw/mips/mips_loongson3.c:709:
+    isa_bus = isa_bus_new(NULL, get_system_memory(), get_system_io(), 
&error_abort);

WARNING: line over 80 characters
#821: FILE: hw/mips/mips_loongson3.c:739:
+    memory_region_add_subregion(get_system_memory(), VIRT_PCI_ECAM_BASE, 
ecam_alias);

WARNING: line over 80 characters
#827: FILE: hw/mips/mips_loongson3.c:745:
+    memory_region_add_subregion(get_system_memory(), VIRT_PCI_MEM_BASE, 
mmio_alias);

WARNING: line over 80 characters
#832: FILE: hw/mips/mips_loongson3.c:750:
+    memory_region_add_subregion(get_system_memory(), VIRT_PCI_IO_BASE, 
pio_alias);

ERROR: space required before the open parenthesis '('
#843: FILE: hw/mips/mips_loongson3.c:761:
+    for(i = 0; i < nb_nics; i++) {

ERROR: braces {} are necessary for all arms of this statement
#846: FILE: hw/mips/mips_loongson3.c:764:
+        if (!nd->model)
[...]

ERROR: braces {} are necessary for all arms of this statement
#870: FILE: hw/mips/mips_loongson3.c:788:
+        if (!machine->cpu_type)
[...]

ERROR: Error messages should not contain newlines
#874: FILE: hw/mips/mips_loongson3.c:792:
+            error_report("Loongson-3/TCG need cpu type Loongson-3A1000\n");

ERROR: braces {} are necessary for all arms of this statement
#878: FILE: hw/mips/mips_loongson3.c:796:
+        if (!machine->cpu_type)
[...]

ERROR: Error messages should not contain newlines
#882: FILE: hw/mips/mips_loongson3.c:800:
+            error_report("Loongson-3/KVM need cpu type Loongson-3A4000\n");

WARNING: line over 80 characters
#903: FILE: hw/mips/mips_loongson3.c:821:
+    /* Allocate RAM/BIOS, 0x00000000~0x10000000 is alias of 
0x80000000~0x90000000 */

WARNING: line over 80 characters
#904: FILE: hw/mips/mips_loongson3.c:822:
+    memory_region_init_rom(bios, NULL, "loongson3.bios", BIOS_SIZE, 
&error_fatal);

ERROR: line over 90 characters
#905: FILE: hw/mips/mips_loongson3.c:823:
+    memory_region_init_alias(ram, NULL, "loongson3.lowram", machine->ram, 0, 
256 * 0x100000);

ERROR: line over 90 characters
#906: FILE: hw/mips/mips_loongson3.c:824:
+    memory_region_init_io(iomem, NULL, &loongson3_pm_ops, NULL, 
"loongson3_pm", PM_MMIO_SIZE);

WARNING: line over 80 characters
#924: FILE: hw/mips/mips_loongson3.c:842:
+        rom_add_blob_fixed("bios", bios_boot_code, sizeof(bios_boot_code), 
0x1fc00000LL);

WARNING: line over 80 characters
#945: FILE: hw/mips/mips_loongson3.c:863:
+        rom_add_blob_fixed("fw_conf", (void*)&fw_config, sizeof(fw_config), 
FW_CONF_ADDR);

ERROR: "(foo*)" should be "(foo *)"
#945: FILE: hw/mips/mips_loongson3.c:863:
+        rom_add_blob_fixed("fw_conf", (void*)&fw_config, sizeof(fw_config), 
FW_CONF_ADDR);

ERROR: braces {} are necessary for all arms of this statement
#952: FILE: hw/mips/mips_loongson3.c:870:
+    if (serial_hd(0))
[...]

ERROR: line over 90 characters
#953: FILE: hw/mips/mips_loongson3.c:871:
+        serial_mm_init(address_space_mem, 0x1fe001e0, 0, env->irq[2], 115200, 
serial_hd(0), DEVICE_NATIVE_ENDIAN);

total: 33 errors, 53 warnings, 915 lines checked

Patch 6/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/7 Checking commit 7b568a8bbbe2 (MAINTAINERS: Add myself as Loongson-3 
maintainer)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[PATCH for-5.1 V2 0/7] mips: Add Loongson-3 machine support (with KVM), Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 1/7] configure: Add KVM target support for MIPS64, Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 2/7] hw/mips: Implement the kvm_type() hook in MachineClass, Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 3/7] hw/mips: Add CPU IRQ3 delivery for KVM, Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 4/7] target/mips: Add Loongson-3 CPU definition, Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 5/7] target/mips: Add more CP0 register for save/restore, Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 6/7] hw/mips: Add Loongson-3 machine support (with KVM), Huacai Chen, 2020/04/30
- [PATCH for-5.1 V2 7/7] MAINTAINERS: Add myself as Loongson-3 maintainer, Huacai Chen, 2020/04/30
- Re: [PATCH for-5.1 V2 0/7] mips: Add Loongson-3 machine support (with KVM), no-reply <=
Prev by Date: Re: [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree
Next by Date: Re: About hardfloat in ppc
Previous by thread: [PATCH for-5.1 V2 7/7] MAINTAINERS: Add myself as Loongson-3 maintainer
Next by thread: [PATCH v3 00/17] 64bit block-layer
Index(es):
- Date
- Thread