[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 24/36] target/arm: Convert Neon VHADD 3-reg-same insns
From: |
Richard Henderson |
Subject: |
Re: [PATCH 24/36] target/arm: Convert Neon VHADD 3-reg-same insns |
Date: |
Thu, 30 Apr 2020 13:59:19 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 4/30/20 11:09 AM, Peter Maydell wrote:
> + for (pass = 0; pass < (a->q ? 4 : 2); pass++) {
> + tmp = neon_load_reg(a->vn, pass);
> + tmp2 = neon_load_reg(a->vm, pass);
> + fn(tmp, tmp, tmp2);
> + tcg_temp_free_i32(tmp2);
> + neon_store_reg(a->vd, pass, tmp);
> + }
> + return true;
> +}
> +
> +#define DO_3SAME_32(INSN, func) \
> + static bool trans_##INSN##_S_3s(DisasContext *s, arg_3same *a) \
> + { \
> + static NeonGenTwoOpFn * const fns[] = { \
> + gen_helper_neon_##func##_s8, \
> + gen_helper_neon_##func##_s16, \
> + gen_helper_neon_##func##_s32, \
> + }; \
> + if (a->size > 2) { \
> + return false; \
> + } \
> + return do_3same_32(s, a, fns[a->size]); \
> + } \
Right, I just talked about the .fni4 hook vs the DO_3SAME_64 patch.
r~
- [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree, (continued)
- [PATCH 20/36] target/arm: Convert Neon 3-reg-same VQRDMLAH/VQRDMLSH to decodetree, Peter Maydell, 2020/04/30
- [PATCH 21/36] target/arm: Convert Neon 3-reg-same SHA to decodetree, Peter Maydell, 2020/04/30
- [PATCH 22/36] target/arm: Move gen_ function typedefs to translate.h, Peter Maydell, 2020/04/30
- [PATCH 23/36] target/arm: Convert Neon 64-bit element 3-reg-same insns, Peter Maydell, 2020/04/30
- [PATCH 24/36] target/arm: Convert Neon VHADD 3-reg-same insns, Peter Maydell, 2020/04/30
- Re: [PATCH 24/36] target/arm: Convert Neon VHADD 3-reg-same insns,
Richard Henderson <=
- [PATCH 25/36] target/arm: Convert Neon VRHADD, VHSUB, VABD 3-reg-same insns to decodetree, Peter Maydell, 2020/04/30
- [PATCH 27/36] target/arm: Convert Neon VABA 3-reg-same to decodetree, Peter Maydell, 2020/04/30
- [PATCH 26/36] target/arm: Convert Neon VQSHL, VRSHL, VQRSHL 3-reg-same insns to decodetree, Peter Maydell, 2020/04/30
- [PATCH 28/36] target/arm: Convert Neon VPMAX/VPMIN 3-reg-same insns to decodetree, Peter Maydell, 2020/04/30
- [PATCH 30/36] target/arm: Convert Neon VQDMULH/VQRDMULH 3-reg-same to decodetree, Peter Maydell, 2020/04/30
- [PATCH 29/36] target/arm: Convert Neon VPADD 3-reg-same insns to decodetree, Peter Maydell, 2020/04/30