[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] device-core: use atomic_set on .realized property
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 3/4] device-core: use atomic_set on .realized property |
|
Date: |
Mon, 4 May 2020 13:22:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 04/05/20 12:45, Stefan Hajnoczi wrote:
>> @@ -983,7 +983,7 @@ static void device_set_realized(Object *obj, bool value,
>> Error **errp)
>> }
>>
>> assert(local_err == NULL);
>> - dev->realized = value;
>> + atomic_set(&dev->realized, value);
> A memory barrier is probably needed so that the atomic_read() thread
> sees up-to-date dev fields.
Yes, it should be a store-release for the false->true case. The
true->false case probably doesn't matter as much.
Paolo
signature.asc
Description: OpenPGP digital signature