[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xl
From: |
Greg Kurz |
Subject: |
[PATCH 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() |
Date: |
Thu, 07 May 2020 19:27:09 +0200 |
User-agent: |
StGit/unknown-version |
The last two arguments have the bool type. Also, we shouldn't raise an
exception when using gdbstub.
This was found while reading the code. Since it only affects the powernv
machine, I didn't dig further to find an actual bug.
Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped
translation"
Signed-off-by: Greg Kurz <address@hidden>
---
target/ppc/mmu-radix64.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index 956519b3ad20..ceeb3dfe2d49 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -335,7 +335,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
*cpu, int rwx,
*/
ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, prtbe_addr,
pate, &h_raddr, &h_prot,
- &h_page_size, 1, 1);
+ &h_page_size, true,
+ cause_excp);
if (ret) {
return ret;
}
@@ -374,7 +375,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
*cpu, int rwx,
do {
ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, pte_addr,
pate, &h_raddr, &h_prot,
- &h_page_size, 1, 1);
+ &h_page_size, true,
+ cause_excp);
if (ret) {
return ret;
}
- [PATCH 0/6] target/ppc: Various clean-up and fixes for radix64, Greg Kurz, 2020/05/07
- [PATCH 1/6] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(), Greg Kurz, 2020/05/07
- [PATCH 2/6] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(), Greg Kurz, 2020/05/07
- [PATCH 3/6] target/ppc: Don't initialize some local variables in ppc_radix64_xlate(), Greg Kurz, 2020/05/07
- [PATCH 4/6] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate(), Greg Kurz, 2020/05/07
- [PATCH 5/6] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate(),
Greg Kurz <=
- [PATCH 6/6] target/ppc: Don't update radix PTE R/C bits with gdbstub, Greg Kurz, 2020/05/07
- Re: [PATCH 0/6] target/ppc: Various clean-up and fixes for radix64, David Gibson, 2020/05/10