[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/19] tcg: Better handling of constants
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 00/19] tcg: Better handling of constants |
Date: |
Fri, 8 May 2020 10:02:52 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/8/20 9:15 AM, Alex Bennée wrote:
>
> Richard Henderson <address@hidden> writes:
>
>> V3 fixes the target/sparc regression during register allocation.
>
> Which patch has the fix in it? I couldn't see any per-patch rev notes.
Patch 3:
> + /*
> + * If the input is readonly, then it cannot also be an
> + * output and aliased to itself. If the input is not
> + * dead after the instruction, we must allocate a new
> + * register and move it.
> + */
> + if (temp_readonly(ts) || !IS_DEAD_ARG(i)) {
> + goto allocate_in_reg;
> + }
> Also I'm sure I reviewed a bunch of these, did they not count because I
> found a bug ;-)
Oops, you're right. I simply missed them, having gotten distracted by the bug.
r~
- [PATCH v3 09/19] tcg: Rename struct tcg_temp_info to TempOptInfo, (continued)
- [PATCH v3 09/19] tcg: Rename struct tcg_temp_info to TempOptInfo, Richard Henderson, 2020/05/08
- [PATCH v3 13/19] tcg/tci: Add special tci_movi_{i32,i64} opcodes, Richard Henderson, 2020/05/08
- [PATCH v3 12/19] tcg/optimize: Use tcg_constant_internal with constant folding, Richard Henderson, 2020/05/08
- [PATCH v3 15/19] tcg: Use tcg_out_dupi_vec from temp_load, Richard Henderson, 2020/05/08
- [PATCH v3 17/19] tcg: Add tcg_reg_alloc_dup2, Richard Henderson, 2020/05/08
- [PATCH v3 16/19] tcg: Increase tcg_out_dupi_vec immediate to int64_t, Richard Henderson, 2020/05/08
- [PATCH v3 14/19] tcg: Remove movi and dupi opcodes, Richard Henderson, 2020/05/08
- [PATCH v3 18/19] tcg/i386: Use tcg_constant_vec with tcg vec expanders, Richard Henderson, 2020/05/08
- [PATCH v3 19/19] tcg: Remove tcg_gen_dup{8,16,32,64}i_vec, Richard Henderson, 2020/05/08
- Re: [PATCH v3 00/19] tcg: Better handling of constants, Alex Bennée, 2020/05/08
- Re: [PATCH v3 00/19] tcg: Better handling of constants,
Richard Henderson <=